[jira] [Commented] (GEODE-7563) Replace uses of ConcurrentHashSet with ConcurrentHashMap.newKeySet()

["Bill Burcham (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995205#comment-16995205 ] 

Bill Burcham commented on GEODE-7563:
-------------------------------------

Since I had to remove the ConcurrentHashSet entry from geode-core/src/main/resources/org/apache/geode/internal/sanctioned-geode-core-serializables.txt the next thing I have to do is analyze the places where ConcurrentHashSet was used (Java classes) to see which, if any, were actually serialized (and which, therefore, might break as a result of the changes in this PR)

We analyzed all the classes that used to use ConcurrentHashSet (and now use ConcurrentHashMap.KeySetView) and in each case, the referenced object is not (directly) serialized. In some cases the "guts" are serialized but we do that by iterating over the KeySetView (as a Set) and send it out as a HashSet.

> Replace uses of ConcurrentHashSet with ConcurrentHashMap.newKeySet()
> --------------------------------------------------------------------
>
>                 Key: GEODE-7563
>                 URL: https://issues.apache.org/jira/browse/GEODE-7563
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Dan Smith
>            Priority: Major
>              Labels: low-hanging-fruit, newbie, starter
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> As of Java 1.8, we can create a concurrent hash set directly from the JDK.
> https://stackoverflow.com/a/6992643



--
This message was sent by Atlassian Jira
(v8.3.4#803005)