You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "kasjer (via GitHub)" <gi...@apache.org> on 2023/03/20 21:37:01 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request, #2963: pic32 use spi_hal bus driver for SPI
kasjer opened a new pull request, #2963:
URL: https://github.com/apache/mynewt-core/pull/2963
This is simple refactor of hal_spi so it can be used with spi_hal bus driver.
When bus driver bus/drivers/spi_hal is added to the target pic32mz_periph_create() function creates proper devices
so applications using bus driver interface can be built.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc commented on a diff in pull request #2963: pic32 use spi_hal bus driver for SPI
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #2963:
URL: https://github.com/apache/mynewt-core/pull/2963#discussion_r1143263151
##########
hw/mcu/microchip/pic32mz/src/hal_spi.c:
##########
@@ -705,3 +705,10 @@ hal_spi_abort(int spi_num)
return 0;
}
+
+int
+hal_spi_init_hw(uint8_t spi_num, uint8_t spi_type,
+ const struct hal_spi_hw_settings *cfg)
+{
+ return hal_spi_init(spi_num, (void *)cfg, spi_type);
Review Comment:
nitpick: maybe cast to const void * ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2963: pic32 use spi_hal bus driver for SPI
Posted by "kasjer (via GitHub)" <gi...@apache.org>.
kasjer merged PR #2963:
URL: https://github.com/apache/mynewt-core/pull/2963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org