You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/04 01:00:20 UTC
[GitHub] [helix] pkuwm opened a new pull request #1212: Update copyright with apache license to pass rat check
pkuwm opened a new pull request #1212:
URL: https://github.com/apache/helix/pull/1212
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Fixes #618
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
(Write a concise description including what, why, how)
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- [ ] The following is the result of the "mvn test" command on the appropriate module:
build with rat check
```
$ mvn clean install -Prat -B -Dmaven.test.skip.exec=true
[INFO] Reactor Summary for Apache Helix 1.0.2-SNAPSHOT:
[INFO]
[INFO] Apache Helix ....................................... SUCCESS [ 2.264 s]
[INFO] Apache Helix :: Metrics Common ..................... SUCCESS [ 1.373 s]
[INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 1.097 s]
[INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [ 2.083 s]
[INFO] Apache Helix :: Helix Common ....................... SUCCESS [ 0.745 s]
[INFO] Apache Helix :: Core ............................... SUCCESS [ 9.589 s]
[INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [ 1.714 s]
[INFO] Apache Helix :: Restful Interface .................. SUCCESS [ 2.616 s]
[INFO] Apache Helix :: Distributed Lock ................... SUCCESS [ 0.481 s]
[INFO] Apache Helix :: HelixAgent ......................... SUCCESS [ 0.702 s]
[INFO] Apache Helix :: Recipes ............................ SUCCESS [ 0.201 s]
[INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [ 0.557 s]
[INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [ 0.590 s]
[INFO] Apache Helix :: Recipes :: distributed lock manager SUCCESS [ 0.496 s]
[INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [ 3.035 s]
[INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [ 0.536 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 28.707 s
[INFO] Finished at: 2020-08-03T17:55:02-07:00
[INFO] ------------------------------------------------------------------------
```
### Commits
- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation (Optional)
- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Code Quality
- [ ] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #1212: Update copyright with apache license to pass rat check
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #1212:
URL: https://github.com/apache/helix/pull/1212
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on pull request #1212: Update copyright with apache license to pass rat check
Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1212:
URL: https://github.com/apache/helix/pull/1212#issuecomment-668334632
Thanks, @narendly, for the review and approval.
This PR is ready to be merged, approved by @narendly
```
Each time we merge code, apache build is triggered but failed because of too many files with unapproved license. We would like to fix it to have helix build success emails.
This PR fixes the build failure by updating license and excluding some files that don't need to do rat check.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on pull request #1212: Update copyright with apache license to pass rat check
Posted by GitBox <gi...@apache.org>.
narendly commented on pull request #1212:
URL: https://github.com/apache/helix/pull/1212#issuecomment-668349631
@pkuwm Good stuff! We needed this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org