You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/06/01 20:31:58 UTC
[GitHub] [phoenix] kadirozde commented on a change in pull request #794: PHOENIX-5928 Index rebuilds without replaying data table mutations
kadirozde commented on a change in pull request #794:
URL: https://github.com/apache/phoenix/pull/794#discussion_r433472807
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java
##########
@@ -82,16 +94,30 @@
protected long maxLookBackInMills;
protected IndexToolVerificationResult verificationResult;
protected IndexVerificationResultRepository verificationResultRepository;
+ protected UngroupedAggregateRegionObserver ungroupedAggregateRegionObserver;
+ protected Map<byte[], NavigableSet<byte[]>> familyMap;
+ protected IndexTool.IndexVerifyType verifyType = IndexTool.IndexVerifyType.NONE;
+ protected boolean verify = false;
public GlobalIndexRegionScanner(RegionScanner innerScanner, final Region region, final Scan scan,
- final RegionCoprocessorEnvironment env) throws IOException {
+ final RegionCoprocessorEnvironment env,
+ UngroupedAggregateRegionObserver ungroupedAggregateRegionObserver) throws IOException {
super(innerScanner);
final Configuration config = env.getConfiguration();
if (scan.getAttribute(BaseScannerRegionObserver.INDEX_REBUILD_PAGING) != null) {
pageSizeInRows = config.getLong(INDEX_REBUILD_PAGE_SIZE_IN_ROWS,
QueryServicesOptions.DEFAULT_INDEX_REBUILD_PAGE_SIZE_IN_ROWS);
}
maxBatchSize = config.getInt(MUTATE_BATCH_SIZE_ATTRIB, QueryServicesOptions.DEFAULT_MUTATE_BATCH_SIZE);
+ maxBatchSizeBytes = config.getLong(MUTATE_BATCH_SIZE_BYTES_ATTRIB,
+ QueryServicesOptions.DEFAULT_MUTATE_BATCH_SIZE_BYTES);
+ blockingMemstoreSize = UngroupedAggregateRegionObserver.getBlockingMemstoreSize(region, config);
Review comment:
Not currently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org