You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/02/03 10:51:00 UTC
[GitHub] [jackrabbit-oak] ShangwenWang opened a new pull request #267: Change the method name "serialize" to "serializeReferences"
ShangwenWang opened a new pull request #267:
URL: https://github.com/apache/jackrabbit-oak/pull/267
The function of this method is to serialize the passed references. However, only naming it as "serialize" cannot describe it clearly.
Given that the class name (_GetReferencesResponseEncoder_) provides lots of semantic information, it would be better to change this method's name into "_serializeReferences_" for providing enough guidance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] ShangwenWang closed pull request #267: Change the method name "serialize" to "serializeReferences"
Posted by GitBox <gi...@apache.org>.
ShangwenWang closed pull request #267:
URL: https://github.com/apache/jackrabbit-oak/pull/267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] ShangwenWang commented on pull request #267: Change the method name "serialize" to "serializeReferences"
Posted by GitBox <gi...@apache.org>.
ShangwenWang commented on pull request #267:
URL: https://github.com/apache/jackrabbit-oak/pull/267#issuecomment-778923189
Does anyone know why build errors happen?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org