You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/07 06:21:41 UTC
[jira] [Commented] (KAFKA-5039) Logging in BlockingChannel and SyncProducer connect

    [ https://issues.apache.org/jira/browse/KAFKA-5039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960348#comment-15960348 ] 

ASF GitHub Bot commented on KAFKA-5039:
---------------------------------------

GitHub user arunmahadevan opened a pull request:

    https://github.com/apache/kafka/pull/2820

    KAFKA-5039: Logging in BlockingChannel and SyncProducer connect

    When an exception is thrown in BlockingChannel::connect, the connection is disconnected but the actual exception is not logged. This later manifests as ClosedChannelException when trying to send. Also the SyncProducer wrongfully logs "Connected to host:port for producing" even in case of exceptions.
    
    The proposed patch logs the exception in BlockingChannel::connect in debug level and logs the "Connected" message in SyncProducer only on successful connection.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arunmahadevan/kafka KAFKA-5039

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2820.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2820
    
----
commit 41ba92d6417f72a205b38988519ed462f967700a
Author: Arun Mahadevan <ar...@apache.org>
Date:   2017-04-07T06:07:57Z

    KAFKA-5039: Logging in BlockingChannel and SyncProducer connect
    
    When an exception is thrown in BlockingChannel::connect, the connection is disconnected but the actual exception is not logged. This later manifests as ClosedChannelException when trying to send. Also the SyncProducer wrongfully logs "Connected to host:port for producing" even in case of exceptions.
    
    The proposed patch logs the exception in BlockingChannel::connect in debug level and logs the "Connected" message in SyncProducer only on successful connection.

----


> Logging in BlockingChannel and SyncProducer connect
> ---------------------------------------------------
>
>                 Key: KAFKA-5039
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5039
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Arun Mahadevan
>            Assignee: Arun Mahadevan
>            Priority: Minor
>
> When an exception is thrown in BlockingChannel::connect, the connection is disconnected but the actual exception is not logged. This later manifests as ClosedChannelException when trying to send. Also the SyncProducer wrongfully logs "Connected to host:port for producing" even in case of exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)