You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/14 01:55:19 UTC
Review Request 64591: Printed out the source profile and ID for a disk
resource.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64591/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
`Resource::DiskInfo::Source` is printed out in the following formats:
TYPE(profile,id):root
If the source has no profile and ID, then "(profile,id)" will be
skipped. If either the profile or the ID is missing, the missing part
will be replaced with an empty string. If the source has no root path,
":root" will be skipped.
Diffs
-----
src/common/resources.cpp 2774372bb52d9d60847a8230282068432b28b054
src/v1/resources.cpp 43d9b0f48c345b4574171cffbd1dc07bda1d1546
Diff: https://reviews.apache.org/r/64591/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64591: Printed out the source profile and ID for a
disk resource.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64591/
-----------------------------------------------------------
(Updated Dec. 15, 2017, 9:44 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Addressed comments.
Repository: mesos
Description
-------
`Resource::DiskInfo::Source` is printed out in the following formats:
TYPE(profile,id):root
If the source has no profile and ID, then "(profile,id)" will be
skipped. If either the profile or the ID is missing, the missing part
will be replaced with an empty string. If the source has no root path,
":root" will be skipped.
Diffs (updated)
-----
src/common/resources.cpp 2774372bb52d9d60847a8230282068432b28b054
src/v1/resources.cpp 43d9b0f48c345b4574171cffbd1dc07bda1d1546
Diff: https://reviews.apache.org/r/64591/diff/2/
Changes: https://reviews.apache.org/r/64591/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64591: Printed out the source profile and ID for a
disk resource.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64591/#review193964
-----------------------------------------------------------
Fix it, then Ship it!
src/v1/resources.cpp
Lines 2124 (patched)
<https://reviews.apache.org/r/64591/#comment272653>
I'd prefer `id` to be at the front
- Jie Yu
On Dec. 14, 2017, 1:55 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64591/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 1:55 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `Resource::DiskInfo::Source` is printed out in the following formats:
>
> TYPE(profile,id):root
>
> If the source has no profile and ID, then "(profile,id)" will be
> skipped. If either the profile or the ID is missing, the missing part
> will be replaced with an empty string. If the source has no root path,
> ":root" will be skipped.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 2774372bb52d9d60847a8230282068432b28b054
> src/v1/resources.cpp 43d9b0f48c345b4574171cffbd1dc07bda1d1546
>
>
> Diff: https://reviews.apache.org/r/64591/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>