You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ie...@apache.org on 2021/04/13 12:23:25 UTC
[beam] 03/04: [BEAM-11712] Fix static analysis warnings and typos
on TPC-DS module
This is an automated email from the ASF dual-hosted git repository.
iemejia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
commit 8fe0c5cee1bab62680ebd92a51aed8f3da80e190
Author: Ismaël Mejía <ie...@gmail.com>
AuthorDate: Tue Apr 13 14:20:54 2021 +0200
[BEAM-11712] Fix static analysis warnings and typos on TPC-DS module
---
.../apache/beam/sdk/tpcds/BeamSqlEnvRunner.java | 3 +-
.../java/org/apache/beam/sdk/tpcds/CsvToRow.java | 4 +-
.../org/apache/beam/sdk/tpcds/QueryReader.java | 3 +-
.../java/org/apache/beam/sdk/tpcds/RowToCsv.java | 2 +-
.../apache/beam/sdk/tpcds/SqlTransformRunner.java | 2 +-
.../beam/sdk/tpcds/TableSchemaJSONLoader.java | 6 +-
.../beam/sdk/tpcds/TpcdsParametersReader.java | 4 +-
.../org/apache/beam/sdk/tpcds/TpcdsRunResult.java | 11 +--
.../org/apache/beam/sdk/tpcds/TpcdsSchemas.java | 102 ++++++++++-----------
.../beam/sdk/tpcds/TableSchemaJSONLoaderTest.java | 3 +-
.../apache/beam/sdk/tpcds/TpcdsSchemasTest.java | 6 +-
11 files changed, 68 insertions(+), 78 deletions(-)
diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/BeamSqlEnvRunner.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/BeamSqlEnvRunner.java
index 69e676f..304fdd2 100644
--- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/BeamSqlEnvRunner.java
+++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/BeamSqlEnvRunner.java
@@ -211,8 +211,7 @@ public class BeamSqlEnvRunner {
// Transform the result from PCollection<Row> into PCollection<String>, and write it to the
// location where results are stored.
PCollection<String> rowStrings =
- rows.apply(
- MapElements.into(TypeDescriptors.strings()).via((Row row) -> row.toString()));
+ rows.apply(MapElements.into(TypeDescriptors.strings()).via(Row::toString));
rowStrings.apply(
TextIO.write()
.to(
diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/CsvToRow.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/CsvToRow.java
index d66b128..d6c8ed8 100644
--- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/CsvToRow.java
+++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/CsvToRow.java
@@ -33,8 +33,8 @@ import org.apache.commons.csv.CSVFormat;
*/
public class CsvToRow extends PTransform<PCollection<String>, PCollection<Row>>
implements Serializable {
- private Schema schema;
- private CSVFormat csvFormat;
+ private final Schema schema;
+ private final CSVFormat csvFormat;
public CSVFormat getCsvFormat() {
return csvFormat;
diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/QueryReader.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/QueryReader.java
index 7b00a37..c6f3253 100644
--- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/QueryReader.java
+++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/QueryReader.java
@@ -35,7 +35,6 @@ public class QueryReader {
*/
public static String readQuery(String queryFileName) throws Exception {
String path = "queries/" + queryFileName + ".sql";
- String query = Resources.toString(Resources.getResource(path), Charsets.UTF_8);
- return query;
+ return Resources.toString(Resources.getResource(path), Charsets.UTF_8);
}
}
diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/RowToCsv.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/RowToCsv.java
index 40a8cc5..a087948 100644
--- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/RowToCsv.java
+++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/RowToCsv.java
@@ -33,7 +33,7 @@ import org.apache.commons.csv.CSVFormat;
*/
public class RowToCsv extends PTransform<PCollection<Row>, PCollection<String>>
implements Serializable {
- private CSVFormat csvFormat;
+ private final CSVFormat csvFormat;
public RowToCsv(CSVFormat csvFormat) {
this.csvFormat = csvFormat;
diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/SqlTransformRunner.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/SqlTransformRunner.java
index 4f56c1a..bea0261 100644
--- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/SqlTransformRunner.java
+++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/SqlTransformRunner.java
@@ -189,7 +189,7 @@ public class SqlTransformRunner {
try {
tables
.apply(SqlTransform.query(queryString))
- .apply(MapElements.into(TypeDescriptors.strings()).via((Row row) -> row.toString()))
+ .apply(MapElements.into(TypeDescriptors.strings()).via(Row::toString))
.apply(
TextIO.write()
.to(
diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TableSchemaJSONLoader.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TableSchemaJSONLoader.java
index b6f8733..0b95853 100644
--- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TableSchemaJSONLoader.java
+++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TableSchemaJSONLoader.java
@@ -18,7 +18,6 @@
package org.apache.beam.sdk.tpcds;
import java.io.IOException;
-import java.net.URISyntaxException;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
@@ -69,8 +68,7 @@ public class TableSchemaJSONLoader {
// If the key of the pair is "type", make some modification before appending it to the
// schemaStringBuilder, then append a comma.
String typeName = (String) pair.getValue();
- if (typeName.toLowerCase().equals("identifier")
- || typeName.toLowerCase().equals("integer")) {
+ if (typeName.equalsIgnoreCase("identifier") || typeName.equalsIgnoreCase("integer")) {
// Use long type to represent int, prevent overflow
schemaStringBuilder.append("bigint");
} else if (typeName.contains("decimal")) {
@@ -106,7 +104,7 @@ public class TableSchemaJSONLoader {
*
* @return The list of names of all tables.
*/
- public static List<String> getAllTableNames() throws IOException, URISyntaxException {
+ public static List<String> getAllTableNames() throws IOException {
ClassLoader classLoader = TableSchemaJSONLoader.class.getClassLoader();
if (classLoader == null) {
throw new RuntimeException("Can't get classloader from TableSchemaJSONLoader.");
diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsParametersReader.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsParametersReader.java
index 8928292..8d7d1a7 100644
--- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsParametersReader.java
+++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsParametersReader.java
@@ -47,7 +47,7 @@ public class TpcdsParametersReader {
/**
* Get and check queries entered by user. This has to be a string of numbers separated by commas
- * or "all" which means run all 99 queiries. All query numbers have to be between 1 and 99.
+ * or "all" which means run all 99 queries. All query numbers have to be between 1 and 99.
*
* @param tpcdsOptions TpcdsOptions object constructed from user input
* @return An array of query names, for example "1,2,7" will be output as "query1,query2,query7"
@@ -57,7 +57,7 @@ public class TpcdsParametersReader {
String queryNums = tpcdsOptions.getQueries();
String[] queryNumArr;
- if (queryNums.toLowerCase().equals("all")) {
+ if (queryNums.equalsIgnoreCase("all")) {
// All 99 TPC-DS queries need to be executed.
queryNumArr = new String[99];
for (int i = 0; i < 99; i++) {
diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsRunResult.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsRunResult.java
index c89a34a..55fdac1 100644
--- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsRunResult.java
+++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsRunResult.java
@@ -50,14 +50,12 @@ public class TpcdsRunResult {
public Date getStartDate() {
Timestamp startTimeStamp = new Timestamp(startTime);
- Date startDate = new Date(startTimeStamp.getTime());
- return startDate;
+ return new Date(startTimeStamp.getTime());
}
public Date getEndDate() {
Timestamp endTimeStamp = new Timestamp(endTime);
- Date endDate = new Date(endTimeStamp.getTime());
- return endDate;
+ return new Date(endTimeStamp.getTime());
}
public double getElapsedTime() {
@@ -80,8 +78,7 @@ public class TpcdsRunResult {
public String getQueryName() {
String jobName = getJobName();
int endIndex = jobName.indexOf("result");
- String queryName = jobName.substring(0, endIndex);
- return queryName;
+ return jobName.substring(0, endIndex);
}
public String getDataSize() throws Exception {
@@ -89,7 +86,7 @@ public class TpcdsRunResult {
return TpcdsParametersReader.getAndCheckDataSize(pipelineOptions.as(TpcdsOptions.class));
}
- public String getDialect() throws Exception {
+ public String getDialect() {
PipelineOptions pipelineOptions = getPipelineOptions();
String queryPlannerClassName =
pipelineOptions.as(BeamSqlPipelineOptions.class).getPlannerName();
diff --git a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsSchemas.java b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsSchemas.java
index 7f3d874..9398dfa 100644
--- a/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsSchemas.java
+++ b/sdks/java/testing/tpcds/src/main/java/org/apache/beam/sdk/tpcds/TpcdsSchemas.java
@@ -73,34 +73,32 @@ public class TpcdsSchemas {
* @return A map of all tpcds table schemas with their table names as keys.
*/
public static Map<String, Schema> getTpcdsSchemasImmutableMap() {
- ImmutableMap<String, Schema> immutableSchemaMap =
- ImmutableMap.<String, Schema>builder()
- .put("call_center", callCenterSchema)
- .put("catalog_page", catalogPageSchema)
- .put("catalog_returns", catalogReturnsSchema)
- .put("catalog_sales", catalogSalesSchema)
- .put("customer", customerSchema)
- .put("customer_address", customerAddressSchema)
- .put("customer_demographics", customerDemographicsSchema)
- .put("date_dim", dateDimSchema)
- .put("household_demographics", householdDemographicsSchema)
- .put("income_band", incomeBandSchema)
- .put("inventory", inventorySchema)
- .put("item", itemSchema)
- .put("promotion", promotionSchema)
- .put("reason", reasonSchema)
- .put("ship_mode", shipModeSchema)
- .put("store", storeSchema)
- .put("store_returns", storeReturnsSchema)
- .put("store_sales", storeSalesSchema)
- .put("time_dim", timeDimSchema)
- .put("warehouse", warehouseSchema)
- .put("web_page", webPageSchema)
- .put("web_returns", webReturnsSchema)
- .put("web_sales", webSalesSchema)
- .put("web_site", webSiteSchema)
- .build();
- return immutableSchemaMap;
+ return ImmutableMap.<String, Schema>builder()
+ .put("call_center", callCenterSchema)
+ .put("catalog_page", catalogPageSchema)
+ .put("catalog_returns", catalogReturnsSchema)
+ .put("catalog_sales", catalogSalesSchema)
+ .put("customer", customerSchema)
+ .put("customer_address", customerAddressSchema)
+ .put("customer_demographics", customerDemographicsSchema)
+ .put("date_dim", dateDimSchema)
+ .put("household_demographics", householdDemographicsSchema)
+ .put("income_band", incomeBandSchema)
+ .put("inventory", inventorySchema)
+ .put("item", itemSchema)
+ .put("promotion", promotionSchema)
+ .put("reason", reasonSchema)
+ .put("ship_mode", shipModeSchema)
+ .put("store", storeSchema)
+ .put("store_returns", storeReturnsSchema)
+ .put("store_sales", storeSalesSchema)
+ .put("time_dim", timeDimSchema)
+ .put("warehouse", warehouseSchema)
+ .put("web_page", webPageSchema)
+ .put("web_returns", webReturnsSchema)
+ .put("web_sales", webSalesSchema)
+ .put("web_site", webSiteSchema)
+ .build();
}
public static Schema getCallCenterSchema() {
@@ -199,7 +197,7 @@ public class TpcdsSchemas {
return webSiteSchema;
}
- private static Schema callCenterSchema =
+ private static final Schema callCenterSchema =
Schema.builder()
.addField("cc_call_center_sk", Schema.FieldType.INT64)
.addField("cc_call_center_id", Schema.FieldType.STRING)
@@ -234,7 +232,7 @@ public class TpcdsSchemas {
.addNullableField("cc_tax_percentage", Schema.FieldType.DOUBLE)
.build();
- private static Schema catalogPageSchema =
+ private static final Schema catalogPageSchema =
Schema.builder()
.addField("cp_catalog_page_sk", Schema.FieldType.INT64)
.addField("cp_catalog_page_id", Schema.FieldType.STRING)
@@ -247,7 +245,7 @@ public class TpcdsSchemas {
.addNullableField("cp_type", Schema.FieldType.STRING)
.build();
- private static Schema catalogReturnsSchema =
+ private static final Schema catalogReturnsSchema =
Schema.builder()
.addNullableField("cr_returned_date_sk", Schema.FieldType.INT64)
.addNullableField("cr_returned_time_sk", Schema.FieldType.INT64)
@@ -278,7 +276,7 @@ public class TpcdsSchemas {
.addNullableField("cr_net_loss", Schema.FieldType.DOUBLE)
.build();
- private static Schema catalogSalesSchema =
+ private static final Schema catalogSalesSchema =
Schema.builder()
.addNullableField("cs_sold_date_sk", Schema.FieldType.INT64)
.addNullableField("cs_sold_time_sk", Schema.FieldType.INT64)
@@ -316,7 +314,7 @@ public class TpcdsSchemas {
.addNullableField("cs_net_profit", Schema.FieldType.DOUBLE)
.build();
- private static Schema customerSchema =
+ private static final Schema customerSchema =
Schema.builder()
.addField("c_customer_sk", Schema.FieldType.INT64)
.addField("c_customer_id", Schema.FieldType.STRING)
@@ -338,7 +336,7 @@ public class TpcdsSchemas {
.addNullableField("c_last_review_date_sk", Schema.FieldType.INT64)
.build();
- private static Schema customerAddressSchema =
+ private static final Schema customerAddressSchema =
Schema.builder()
.addField("ca_address_sk", Schema.FieldType.INT64)
.addField("ca_address_id", Schema.FieldType.STRING)
@@ -355,7 +353,7 @@ public class TpcdsSchemas {
.addNullableField("ca_location_type", Schema.FieldType.STRING)
.build();
- private static Schema customerDemographicsSchema =
+ private static final Schema customerDemographicsSchema =
Schema.builder()
.addField("cd_demo_sk", Schema.FieldType.INT64)
.addNullableField("cd_gender", Schema.FieldType.STRING)
@@ -368,7 +366,7 @@ public class TpcdsSchemas {
.addNullableField("cd_dep_college_count", Schema.FieldType.INT64)
.build();
- private static Schema dateDimSchema =
+ private static final Schema dateDimSchema =
Schema.builder()
.addField("d_date_sk", Schema.FieldType.INT64)
.addField("d_date_id", Schema.FieldType.STRING)
@@ -400,7 +398,7 @@ public class TpcdsSchemas {
.addNullableField("d_current_year", Schema.FieldType.STRING)
.build();
- private static Schema householdDemographicsSchema =
+ private static final Schema householdDemographicsSchema =
Schema.builder()
.addField("hd_demo_sk", Schema.FieldType.INT64)
.addNullableField("hd_income_band_sk", Schema.FieldType.INT64)
@@ -409,14 +407,14 @@ public class TpcdsSchemas {
.addNullableField("hd_vehicle_count", Schema.FieldType.INT64)
.build();
- private static Schema incomeBandSchema =
+ private static final Schema incomeBandSchema =
Schema.builder()
.addField("ib_income_band_sk", Schema.FieldType.INT64)
.addNullableField("ib_lower_bound", Schema.FieldType.INT64)
.addNullableField("ib_upper_bound", Schema.FieldType.INT64)
.build();
- private static Schema inventorySchema =
+ private static final Schema inventorySchema =
Schema.builder()
.addField("inv_date_sk", Schema.FieldType.INT32)
.addField("inv_item_sk", Schema.FieldType.INT32)
@@ -424,7 +422,7 @@ public class TpcdsSchemas {
.addNullableField("inv_quantity_on_hand", Schema.FieldType.INT32)
.build();
- private static Schema itemSchema =
+ private static final Schema itemSchema =
Schema.builder()
.addField("i_item_sk", Schema.FieldType.INT64)
.addField("i_item_id", Schema.FieldType.STRING)
@@ -450,7 +448,7 @@ public class TpcdsSchemas {
.addNullableField("i_product_name", Schema.FieldType.STRING)
.build();
- private static Schema promotionSchema =
+ private static final Schema promotionSchema =
Schema.builder()
.addField("p_promo_sk", Schema.FieldType.INT64)
.addField("p_promo_id", Schema.FieldType.STRING)
@@ -473,14 +471,14 @@ public class TpcdsSchemas {
.addNullableField("p_discount_active", Schema.FieldType.STRING)
.build();
- private static Schema reasonSchema =
+ private static final Schema reasonSchema =
Schema.builder()
.addField("r_reason_sk", Schema.FieldType.INT64)
.addField("r_reason_id", Schema.FieldType.STRING)
.addNullableField("r_reason_desc", Schema.FieldType.STRING)
.build();
- private static Schema shipModeSchema =
+ private static final Schema shipModeSchema =
Schema.builder()
.addField("sm_ship_mode_sk", Schema.FieldType.INT64)
.addField("sm_ship_mode_id", Schema.FieldType.STRING)
@@ -490,7 +488,7 @@ public class TpcdsSchemas {
.addNullableField("sm_contract", Schema.FieldType.STRING)
.build();
- private static Schema storeSchema =
+ private static final Schema storeSchema =
Schema.builder()
.addField("s_store_sk", Schema.FieldType.INT64)
.addField("s_store_id", Schema.FieldType.STRING)
@@ -523,7 +521,7 @@ public class TpcdsSchemas {
.addNullableField("s_tax_percentage", Schema.FieldType.DOUBLE)
.build();
- private static Schema storeReturnsSchema =
+ private static final Schema storeReturnsSchema =
Schema.builder()
.addNullableField("sr_returned_date_sk", Schema.FieldType.INT64)
.addNullableField("sr_return_time_sk", Schema.FieldType.INT64)
@@ -547,7 +545,7 @@ public class TpcdsSchemas {
.addNullableField("sr_net_loss", Schema.FieldType.DOUBLE)
.build();
- private static Schema storeSalesSchema =
+ private static final Schema storeSalesSchema =
Schema.builder()
.addNullableField("ss_sold_date_sk", Schema.FieldType.INT64)
.addNullableField("ss_sold_time_sk", Schema.FieldType.INT64)
@@ -574,7 +572,7 @@ public class TpcdsSchemas {
.addNullableField("ss_net_profit", Schema.FieldType.DOUBLE)
.build();
- private static Schema timeDimSchema =
+ private static final Schema timeDimSchema =
Schema.builder()
.addField("t_time_sk", Schema.FieldType.INT64)
.addField("t_time_id", Schema.FieldType.STRING)
@@ -588,7 +586,7 @@ public class TpcdsSchemas {
.addNullableField("t_meal_time", Schema.FieldType.STRING)
.build();
- private static Schema warehouseSchema =
+ private static final Schema warehouseSchema =
Schema.builder()
.addField("w_warehouse_sk", Schema.FieldType.INT64)
.addField("w_warehouse_id", Schema.FieldType.STRING)
@@ -606,7 +604,7 @@ public class TpcdsSchemas {
.addNullableField("w_gmt_offset", Schema.FieldType.DOUBLE)
.build();
- private static Schema webPageSchema =
+ private static final Schema webPageSchema =
Schema.builder()
.addField("wp_web_page_sk", Schema.FieldType.INT64)
.addField("wp_web_page_id", Schema.FieldType.STRING)
@@ -624,7 +622,7 @@ public class TpcdsSchemas {
.addNullableField("wp_max_ad_count", Schema.FieldType.INT64)
.build();
- private static Schema webReturnsSchema =
+ private static final Schema webReturnsSchema =
Schema.builder()
.addNullableField("wr_returned_date_sk", Schema.FieldType.INT64)
.addNullableField("wr_returned_time_sk", Schema.FieldType.INT64)
@@ -652,7 +650,7 @@ public class TpcdsSchemas {
.addNullableField("wr_net_loss", Schema.FieldType.DOUBLE)
.build();
- private static Schema webSalesSchema =
+ private static final Schema webSalesSchema =
Schema.builder()
.addNullableField("ws_sold_date_sk", Schema.FieldType.INT32)
.addNullableField("ws_sold_time_sk", Schema.FieldType.INT32)
@@ -690,7 +688,7 @@ public class TpcdsSchemas {
.addNullableField("ws_net_profit", Schema.FieldType.DOUBLE)
.build();
- private static Schema webSiteSchema =
+ private static final Schema webSiteSchema =
Schema.builder()
.addField("web_site_sk", Schema.FieldType.STRING)
.addField("web_site_id", Schema.FieldType.STRING)
diff --git a/sdks/java/testing/tpcds/src/test/java/org/apache/beam/sdk/tpcds/TableSchemaJSONLoaderTest.java b/sdks/java/testing/tpcds/src/test/java/org/apache/beam/sdk/tpcds/TableSchemaJSONLoaderTest.java
index 651d6f0..45f6f91 100644
--- a/sdks/java/testing/tpcds/src/test/java/org/apache/beam/sdk/tpcds/TableSchemaJSONLoaderTest.java
+++ b/sdks/java/testing/tpcds/src/test/java/org/apache/beam/sdk/tpcds/TableSchemaJSONLoaderTest.java
@@ -20,7 +20,6 @@ package org.apache.beam.sdk.tpcds;
import static org.junit.Assert.assertEquals;
import java.io.IOException;
-import java.net.URISyntaxException;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
@@ -140,7 +139,7 @@ public class TableSchemaJSONLoaderTest {
}
@Test
- public void testGetAllTableNames() throws IOException, URISyntaxException {
+ public void testGetAllTableNames() throws IOException {
List<String> tableNames = TableSchemaJSONLoader.getAllTableNames();
Collections.sort(tableNames);
List<String> expectedTableNames =
diff --git a/sdks/java/testing/tpcds/src/test/java/org/apache/beam/sdk/tpcds/TpcdsSchemasTest.java b/sdks/java/testing/tpcds/src/test/java/org/apache/beam/sdk/tpcds/TpcdsSchemasTest.java
index 9c43935..9f2397c 100644
--- a/sdks/java/testing/tpcds/src/test/java/org/apache/beam/sdk/tpcds/TpcdsSchemasTest.java
+++ b/sdks/java/testing/tpcds/src/test/java/org/apache/beam/sdk/tpcds/TpcdsSchemasTest.java
@@ -36,7 +36,7 @@ public class TpcdsSchemasTest {
}
@Test
- public void testCallCenterSchema() throws Exception {
+ public void testCallCenterSchema() {
Schema callCenterSchema =
Schema.builder()
.addField("cc_call_center_sk", Schema.FieldType.INT64)
@@ -77,7 +77,7 @@ public class TpcdsSchemasTest {
}
@Test
- public void testCatalogPageSchemaNullable() throws Exception {
+ public void testCatalogPageSchemaNullable() {
Schema catalogPageSchemaNullable =
Schema.builder()
.addNullableField("cp_catalog_page_sk", Schema.FieldType.INT64)
@@ -97,7 +97,7 @@ public class TpcdsSchemasTest {
}
@Test
- public void testCustomerAddressSchemaNullable() throws Exception {
+ public void testCustomerAddressSchemaNullable() {
Schema customerAddressSchemaNullable =
Schema.builder()
.addNullableField("ca_address_sk", Schema.FieldType.INT64)