You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ppoulosk <gi...@git.apache.org> on 2016/08/31 02:31:01 UTC
[GitHub] storm pull request #1662: [STORM-1344] Add check for table
GitHub user ppoulosk opened a pull request:
https://github.com/apache/storm/pull/1662
[STORM-1344] Add check for table
Works around STORM-1344 by ensuring table is not double-created.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ppoulosk/storm STORM-1344
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1662.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1662
----
commit 2da0b1df48f4990e5d469116b101204d675ef44b
Author: Paul Poulosky <pp...@yahoo-inc.com>
Date: 2016-08-31T02:29:11Z
Add check for table
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1662: [STORM-1344] Remove sql command from storm-jdbc bu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Remove sql command from storm-jdbc build.
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1662
@ppoulosk
Could you rebase this into master and squash commits into one? I guess discarding first commit would be good.
Also please add STORM-1344 as prefix to commit message since we don't get any information from the commit message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Remove sql command from storm-jdbc build.
Posted by ppoulosk <gi...@git.apache.org>.
Github user ppoulosk commented on the issue:
https://github.com/apache/storm/pull/1662
@abellina Yes. I've now pushed the change without the plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Add check for table
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1662
We need to ensure that created table from unit tests will be dropped when cleaning up tests. Removing data directory would be also OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Add check for table
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1662
@abellina I got what you are saying.
@ppoulosk Let's remove test.sql and relevant setting from pom.xml since JdbcClientTest is already in charge to create table.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Add check for table
Posted by ppoulosk <gi...@git.apache.org>.
Github user ppoulosk commented on the issue:
https://github.com/apache/storm/pull/1662
Fixed. Re-ran tests. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Remove sql command from storm-jdbc build.
Posted by abellina <gi...@git.apache.org>.
Github user abellina commented on the issue:
https://github.com/apache/storm/pull/1662
@ppoulosk were you able to test without the plugin all together?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Remove sql command from storm-jdbc build.
Posted by ppoulosk <gi...@git.apache.org>.
Github user ppoulosk commented on the issue:
https://github.com/apache/storm/pull/1662
@HeartSaVioR Thanks for the review!! I've squashed commits and added JIRA to commit comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Remove sql command from storm-jdbc build.
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1662
OK. Checked changeset doesn't affect the build result. Nice work. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Add check for table
Posted by ppoulosk <gi...@git.apache.org>.
Github user ppoulosk commented on the issue:
https://github.com/apache/storm/pull/1662
@HeartSaVioR, @abellina, will fix as you suggest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Add check for table
Posted by abellina <gi...@git.apache.org>.
Github user abellina commented on the issue:
https://github.com/apache/storm/pull/1662
could we remove the file all together? Seems like unit tests are also creating that table...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Remove sql command from storm-jdbc build.
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1662
still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1662: [STORM-1344] Remove sql command from storm-jdbc build.
Posted by abellina <gi...@git.apache.org>.
Github user abellina commented on the issue:
https://github.com/apache/storm/pull/1662
+1 Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---