You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/06/30 21:27:44 UTC
[GitHub] [qpid-dispatch] ChugR opened a new pull request #770: Dispatch 1585 - Add vhost aliases for configuration sharing
ChugR opened a new pull request #770:
URL: https://github.com/apache/qpid-dispatch/pull/770
This PR defines:
- configuration attribute to specify the aliases
- policy code to enforce legal specifications
- configuration tests
- mock operational tests
This PR does not demonstrate actual AMQP Open performative hostnames getting policy to use aliased vhost policy settings. That is on the way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #770: Dispatch 1585 - Add vhost aliases for configuration sharing
Posted by GitBox <gi...@apache.org>.
ChugR commented on a change in pull request #770:
URL: https://github.com/apache/qpid-dispatch/pull/770#discussion_r472366106
##########
File path: docs/books/modules/user-guide/creating-vhost-policies.adoc
##########
@@ -54,6 +55,11 @@ The literal hostname of the vhost (the messaging endpoint) or a pattern that mat
+
If `enableVhostNamePatterns` is set to `true`, you can use wildcards to specify a pattern that matches a range of hostnames. For more information, see xref:vhost-policy-hostname-pattern-matching-rules-{context}[].
+`aliases`::
+Alternative literal hostnames or patterns that direct the router to use the settings in this vhost. Alias hostnames that match an incoming connection will use the settings defined in the contained vhost. In a multi-tenant configuration a connection to a vhost alias will use the base vhost hostname for the tenant namespace. In this example if a connection is directed to vhost `example.org` then the settings from the base vhost hostname `example.com` will apply and `example.com` will be the tenant namespace. Vhost `hostname` and `aliases` settings from all vhosts are shared in a single list and must be unique.
Review comment:
Yes, I think it's fine. Please submit that as a separate PR. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #770: Dispatch 1585 - Add vhost aliases for configuration sharing
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #770:
URL: https://github.com/apache/qpid-dispatch/pull/770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] pwright commented on a change in pull request #770: Dispatch 1585 - Add vhost aliases for configuration sharing
Posted by GitBox <gi...@apache.org>.
pwright commented on a change in pull request #770:
URL: https://github.com/apache/qpid-dispatch/pull/770#discussion_r472304237
##########
File path: docs/books/modules/user-guide/creating-vhost-policies.adoc
##########
@@ -54,6 +55,11 @@ The literal hostname of the vhost (the messaging endpoint) or a pattern that mat
+
If `enableVhostNamePatterns` is set to `true`, you can use wildcards to specify a pattern that matches a range of hostnames. For more information, see xref:vhost-policy-hostname-pattern-matching-rules-{context}[].
+`aliases`::
+Alternative literal hostnames or patterns that direct the router to use the settings in this vhost. Alias hostnames that match an incoming connection will use the settings defined in the contained vhost. In a multi-tenant configuration a connection to a vhost alias will use the base vhost hostname for the tenant namespace. In this example if a connection is directed to vhost `example.org` then the settings from the base vhost hostname `example.com` will apply and `example.com` will be the tenant namespace. Vhost `hostname` and `aliases` settings from all vhosts are shared in a single list and must be unique.
Review comment:
Alternative literal hostnames or patterns that direct the router to use the settings in this vhost.
Alias hostnames that match an incoming connection use the settings defined in the vhost section.
In a multi-tenant configuration, a connection to a vhost alias uses the base vhost hostname for the tenant namespace.
In this example if a connection is directed to vhost `example.org` then the settings from the base vhost hostname `example.com` apply and `example.com` becomes the tenant namespace.
Vhost `hostname` and `aliases` settings from all vhosts must be unique.
@ChugR Not sure if my second sentence is correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #770: Dispatch 1585 - Add vhost aliases for configuration sharing
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #770:
URL: https://github.com/apache/qpid-dispatch/pull/770#discussion_r450937139
##########
File path: python/qpid_dispatch/management/qdrouter.json
##########
@@ -1945,6 +1945,13 @@
"required": true,
"create": true
},
+ "aliases": {
+ "type": "string",
+ "description": "Alternate hostnames that share this vhost configuation. Hosts named in this attribute are treated as if this vhost was defined with the alias name in the vhost 'hostname' attribute. This attribute is implemented to help with multitennant configurations where multiple vhosts share a common configuration. The string is a comma- or space-separated list of literal hostnames or hostname patterns. A vhost aliases hostname must be unique across all vhost hostnames and all of their aliases.",
Review comment:
spelling "multiteNNant"
##########
File path: python/qpid_dispatch_internal/policy/policy_manager.py
##########
@@ -169,6 +180,23 @@ def set_max_message_size(self, size):
:return: none
"""
self._policy_local.set_max_message_size(size)
+
+#
+#
+#
+def policy_lookup_vhost_alias(mgr, vhost):
+ """
+ Look up a user in the policy database
+ Called by C code
+ @param mgr:
+ @param user:
Review comment:
remove unused params?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org