You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Eric Haszlakiewicz (JIRA)" <ji...@apache.org> on 2009/02/03 00:05:59 UTC
[jira] Created: (AXIS2C-1341) adb generated code doesn't escape xml
correctly
adb generated code doesn't escape xml correctly
-----------------------------------------------
Key: AXIS2C-1341
URL: https://issues.apache.org/jira/browse/AXIS2C-1341
Project: Axis2-C
Issue Type: Bug
Components: code generation
Affects Versions: 1.4.0, Current (Nightly), 1.4.1, 1.5.0, 1.6.0
Reporter: Eric Haszlakiewicz
The foo_serialize() functions generated by the adb-codegen module do not correctly call axutil_xml_quote_string() in all necessary cases. This causes requests that contain characters such as '<', etc... to fail due to malformed xml.
The attached patch corrects this for one particular case that was causing problems for me.
I can't tell for sure, but it looks like there are almost certainly other cases that needs to be escaped as well. Either this issue should remain open until those are fixed, even after my patch is applied, or I can create a new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AXIS2C-1341) adb generated code doesn't escape xml
correctly
Posted by "Eric Haszlakiewicz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Haszlakiewicz updated AXIS2C-1341:
---------------------------------------
Attachment: CADBBeanTemplateSource.xsl.diff
The patch to call axutil_xml_quote_string() in one additional case.
> adb generated code doesn't escape xml correctly
> -----------------------------------------------
>
> Key: AXIS2C-1341
> URL: https://issues.apache.org/jira/browse/AXIS2C-1341
> Project: Axis2-C
> Issue Type: Bug
> Components: code generation
> Affects Versions: 1.4.0, Current (Nightly), 1.4.1, 1.5.0, 1.6.0
> Reporter: Eric Haszlakiewicz
> Attachments: CADBBeanTemplateSource.xsl.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The foo_serialize() functions generated by the adb-codegen module do not correctly call axutil_xml_quote_string() in all necessary cases. This causes requests that contain characters such as '<', etc... to fail due to malformed xml.
> The attached patch corrects this for one particular case that was causing problems for me.
> I can't tell for sure, but it looks like there are almost certainly other cases that needs to be escaped as well. Either this issue should remain open until those are fixed, even after my patch is applied, or I can create a new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AXIS2C-1341) adb generated code doesn't escape
xml correctly
Posted by "Dimuthu Gamage (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2C-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dimuthu Gamage resolved AXIS2C-1341.
------------------------------------
Resolution: Fixed
Patch is applied, Thanks for the patch.
Looks like we have axutil_xml_quote_string for the two required places. I think that is all we have to call it. So I mark this as resolved.
> adb generated code doesn't escape xml correctly
> -----------------------------------------------
>
> Key: AXIS2C-1341
> URL: https://issues.apache.org/jira/browse/AXIS2C-1341
> Project: Axis2-C
> Issue Type: Bug
> Components: code generation
> Affects Versions: 1.4.0, Current (Nightly), 1.4.1, 1.5.0, 1.6.0
> Reporter: Eric Haszlakiewicz
> Attachments: CADBBeanTemplateSource.xsl.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The foo_serialize() functions generated by the adb-codegen module do not correctly call axutil_xml_quote_string() in all necessary cases. This causes requests that contain characters such as '<', etc... to fail due to malformed xml.
> The attached patch corrects this for one particular case that was causing problems for me.
> I can't tell for sure, but it looks like there are almost certainly other cases that needs to be escaped as well. Either this issue should remain open until those are fixed, even after my patch is applied, or I can create a new issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.