[jira] Commented: (OFBIZ-3959) Introduce a ModelEntityReaderBuilder to decouple ModelEntity and ModelReader

["Adrian Crum (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915436#action_12915436 ] 

Adrian Crum commented on OFBIZ-3959:
------------------------------------

If anyone is interested in contributing to this effort, I can create a branch for it.

Another thing that could be done (outside the scope of this issue but worth mentioning) would be to convert models to the visitor pattern, and move all behaviors to visitors. That change - coupled with the builder change - would result in models that are nothing more than data structures.


> Introduce a ModelEntityReaderBuilder to decouple ModelEntity and ModelReader
> ----------------------------------------------------------------------------
>
>                 Key: OFBIZ-3959
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3959
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: chris snow
>            Priority: Minor
>
> ModelEntity is quite tightly coupled to ModelReader.  I'm assuming ModelEntity is primarily responsible for representing a model of an entity, however, it is also mixed with logic for building itself from the xml definition.  For me it seems like the build logic should be moved to another class, e.g. ModelEntityReaderBuilder that is responsible for building the ModelEntity from the ModelReader?
> See: http://ofbiz.135035.n4.nabble.com/entity-engine-separation-of-concerns-td2715929.html#a2715929

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.