You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2009/05/21 02:53:21 UTC
svn commit: r776903 - in /hadoop/hbase/trunk: CHANGES.txt
src/java/org/apache/hadoop/hbase/regionserver/MemcacheFlusher.java
Author: apurtell
Date: Thu May 21 00:53:21 2009
New Revision: 776903
URL: http://svn.apache.org/viewvc?rev=776903&view=rev
Log:
HBASE-1415 Stuck on memcache flush
Modified:
hadoop/hbase/trunk/CHANGES.txt
hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/MemcacheFlusher.java
Modified: hadoop/hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=776903&r1=776902&r2=776903&view=diff
==============================================================================
--- hadoop/hbase/trunk/CHANGES.txt (original)
+++ hadoop/hbase/trunk/CHANGES.txt Thu May 21 00:53:21 2009
@@ -146,6 +146,7 @@
HBASE-1441 NPE in ProcessRegionStatusChange#getMetaRegion
HBASE-1162 CME in Master in RegionManager.applyActions
HBASE-1010 IOE on regionserver shutdown because hadn't opened an HLog
+ HBASE-1415 Stuck on memcache flush
IMPROVEMENTS
HBASE-1089 Add count of regions on filesystem to master UI; add percentage
Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/MemcacheFlusher.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/MemcacheFlusher.java?rev=776903&r1=776902&r2=776903&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/MemcacheFlusher.java (original)
+++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/MemcacheFlusher.java Thu May 21 00:53:21 2009
@@ -222,27 +222,34 @@
* not flushed.
*/
private boolean flushRegion(HRegion region, boolean removeFromQueue) {
- // Wait until it is safe to flush.
- boolean toomany;
- do {
- toomany = false;
+ // Wait until it is safe to flush
+ int count = 0;
+ boolean triggered = false;
+ while (count++ < (blockingWaitTime / 500)) {
for (Store hstore: region.stores.values()) {
- int files = hstore.getStorefilesCount();
- if (files > this.blockingStoreFilesNumber) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Too many store files in store " + hstore + ": " +
- files + ", waiting");
- }
- toomany = true;
+ if (hstore.getStorefilesCount() > this.blockingStoreFilesNumber) {
+ // always request a compaction
server.compactSplitThread.compactionRequested(region, getName());
+ // only log once
+ if (!triggered) {
+ LOG.info("Too many store files for region " + region + ": " +
+ hstore.getStorefilesCount() + ", waiting");
+ triggered = true;
+ }
try {
- Thread.sleep(blockingWaitTime);
+ Thread.sleep(500);
} catch (InterruptedException e) {
// ignore
}
+ continue;
}
}
- } while (toomany);
+ if (triggered) {
+ LOG.info("Compaction completed on region " + region +
+ ", proceeding");
+ }
+ break;
+ }
synchronized (regionsInQueue) {
// See comment above for removeFromQueue on why we do not
// take the region out of the set. If removeFromQueue is true, remove it