You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/03/07 22:49:00 UTC
[jira] [Work logged] (GOBBLIN-1795) Make Manifest based copy to support facl
[ https://issues.apache.org/jira/browse/GOBBLIN-1795?focusedWorklogId=849693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-849693 ]
ASF GitHub Bot logged work on GOBBLIN-1795:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/23 22:48
Start Date: 07/Mar/23 22:48
Worklog Time Spent: 10m
Work Description: ZihanLi58 opened a new pull request, #3654:
URL: https://github.com/apache/gobblin/pull/3654
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1795
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
1. Compare facl when we compare and determine whether the file has the desired owner and permissions
2. Make the common path configurable so that we won't try to set the owner and permission for the root dir every time
3. Add setAcl and getAcl support in FileSystemDecorator so that we won't fail with operation not support exception
4. Catch the exception when we fail to set the owner or group for the directory. Now we will fail the first container, and the second container will see dir exist and won't try to set it again, so we essentially succeed even if we fail to set the owner nowadays. And this behavior is the same as safeSetPathPermission() method for file permission. So change the code to directly catch the exception in the first place and log out the warning message.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Unit test
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
5. Subject does not end with a period
6. Subject uses the imperative mood ("add", not "adding")
7. Body wraps at 72 characters
8. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 849693)
Remaining Estimate: 0h
Time Spent: 10m
> Make Manifest based copy to support facl
> ----------------------------------------
>
> Key: GOBBLIN-1795
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1795
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> # Compare facl when we compare and determine whether the file has the desired owner and permissions
> # Make the common path configurable so that we won't try to set the owner and permission for the root dir every time (Since the root dir might have a different owner when we try to do that, the copy job will fail to set the owner )
--
This message was sent by Atlassian Jira
(v8.20.10#820010)