You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/04 12:05:08 UTC
[GitHub] [skywalking-agent-test-tool] dmsolr opened a new pull request #5:
remove protocol v1 and fix checkstyle
dmsolr opened a new pull request #5: remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] dmsolr commented on issue #5: remove
protocol v1 and fix checkstyle
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #5: remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5#issuecomment-594484552
I have tested in agent plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on a change in pull
request #5: Remove protocol v1 and fix checkstyle
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5: Remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5#discussion_r388029520
##########
File path: mock-collector/src/test/resources/expect-data.yaml
##########
@@ -15,26 +15,26 @@
# limitations under the License.
expectData:
- registryItem:
- - applications:
- - test-applicationCode1: nq 0 // the application id of test-applicationCode is 3
- - test-applicationCode2: nq 0
+ - services:
+ - test-serviceName1: nq 0 // the application id of test-serviceName is 3
Review comment:
You miss this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on a change in pull
request #5: Remove protocol v1 and fix checkstyle
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5: Remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5#discussion_r387745253
##########
File path: validator/src/main/java/org/apache/skywalking/plugin/test/agent/tool/validator/assertor/exception/RegistryOperationNamesOfApplicationNotFoundException.java
##########
@@ -29,7 +29,8 @@ public RegistryOperationNamesOfApplicationNotFoundException(RegistryOperationNam
@Override
public String getCauseMessage() {
- return String.format("RegistryOperationNamesOfApplicationNotFoundException %s\nexpected: %s\nactual: %s\n", applicationCode
- .applicationCode(), applicationCode.operationName(), "NOT FOUND");
+ return String.format(
+ "RegistryOperationNamesOfApplicationNotFoundException %s\nexpected: %s\nactual: %s\n", applicationCode
Review comment:
You miss this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on issue #5: Remove
protocol v1 and fix checkstyle
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5: Remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5#issuecomment-594986583
Merged, please forward to main repo and lua repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] dmsolr commented on issue #5: Remove
protocol v1 and fix checkstyle
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #5: Remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5#issuecomment-594993010
> Please use `commit id download` rather than `git submodule` in the main repo please.
Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on a change in pull
request #5: Remove protocol v1 and fix checkstyle
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5: Remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5#discussion_r387719232
##########
File path: validator/src/main/java/org/apache/skywalking/plugin/test/agent/tool/validator/assertor/ApplicationAssert.java
##########
@@ -42,7 +42,7 @@ public static void assertEquals(List<RegistryApplication> expected, List<Registr
}
private static RegistryApplication getMatchApplication(List<RegistryApplication> actual,
- RegistryApplication application) {
+ RegistryApplication application) {
Review comment:
@dmsolr I mean such as this file name. Application* is the old name, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng merged pull request #5:
Remove protocol v1 and fix checkstyle
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5: Remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] dmsolr commented on issue #5: Remove
protocol v1 and fix checkstyle
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #5: Remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5#issuecomment-594573651
```yaml
registryItems:
services:
- {canal-scenario: 2}
instances:
- {canal-scenario: 1}
operationNames:
- canal-scenario: [/canal-scenario/case/healthCheck, /canal-scenario/case/canal-case]
heartbeat: []
segmentItems:
- serviceName: canal-scenario
segmentSize: 2
segments:
- segmentId: 1.35.15833332977840000
spans:
- operationName: /canal-scenario/case/healthCheck
operationId: 0
parentSpanId: -1
spanId: 0
spanLayer: Http
startTime: 1583333297791
endTime: 1583333298137
componentId: 1
componentName: ''
isError: false
spanType: Entry
peer: ''
peerId: 0
tags:
- {key: url, value: 'http://localhost:8080/canal-scenario/case/healthCheck'}
- {key: http.method, value: HEAD}
- segmentId: 1.36.15833332982070000
spans:
- operationName: Canal/example
operationId: 0
parentSpanId: 0
spanId: 1
spanLayer: Unknown
startTime: 1583333298302
endTime: 1583333298326
componentId: 54
componentName: ''
isError: false
spanType: Exit
peer: canal-server 172.21.0.3:11111
peerId: 0
tags:
- {key: batchSize, value: '1000'}
- {key: destination, value: example}
- operationName: /canal-scenario/case/canal-case
operationId: 0
parentSpanId: -1
spanId: 0
spanLayer: Http
startTime: 1583333298207
endTime: 1583333298382
componentId: 1
componentName: ''
isError: false
spanType: Entry
peer: ''
peerId: 0
tags:
- {key: url, value: 'http://localhost:8080/canal-scenario/case/canal-case'}
- {key: http.method, value: GET}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on issue #5: Remove
protocol v1 and fix checkstyle
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5: Remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5#issuecomment-594986734
Please use `commit id download` rather than `git submodule` in the main repo please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on a change in pull
request #5: Remove protocol v1 and fix checkstyle
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5: Remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5#discussion_r388029583
##########
File path: mock-collector/src/test/resources/sample-data.yaml
##########
@@ -16,26 +16,26 @@
#
validateData:
- registryItem:
- - applications:
- - test-applicationCode1: 3 // the application id of test-applicationCode is 3
- - test-applicationCode2: 1
+ - services:
+ - test-serviceName1: 3 // the application id of test-serviceName is 3
Review comment:
This
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-agent-test-tool] wu-sheng commented on a change in pull
request #5: Remove protocol v1 and fix checkstyle
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5: Remove protocol v1 and fix checkstyle
URL: https://github.com/apache/skywalking-agent-test-tool/pull/5#discussion_r387745554
##########
File path: validator/src/main/java/org/apache/skywalking/plugin/test/agent/tool/validator/assertor/exception/RegistryInstanceOfApplicationNotFoundException.java
##########
@@ -29,6 +29,9 @@ public RegistryInstanceOfApplicationNotFoundException(String applicationCode) {
@Override
public String getCauseMessage() {
- return String.format("RegistryInstanceOfApplicationNotFoundException\nexpected: Instances of Service(%s)" + "\nactual: %s\n", applicationCode, "NOT FOUND");
+ return String.format(
+ "RegistryInstanceOfApplicationNotFoundException\nexpected: Instances of Service(%s)" + "\nactual: %s\n",
Review comment:
And this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services