You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2017/09/12 13:55:51 UTC
[GitHub] brooklyn-dist pull request #105: Update Brooklyn vagrant
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-dist/pull/105
Update Brooklyn vagrant
This updates the vagrant configuration to:
- use the latest CentOS
- use the new RPM package to install Brooklyn.
It requires #104 to be merged first
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-dist feature/vagrant-rpm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-dist/pull/105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #105
----
commit 9f640e84d434388749e32d05cb8c10577d20e5f6
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Date: 2017-09-12T13:54:19Z
Update vagrant configuration (centos 7.x) and use the new RPM package to install Brooklyn
----
---
[GitHub] brooklyn-dist pull request #105: Update Brooklyn vagrant to use RPM
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-dist/pull/105
---
[GitHub] brooklyn-dist pull request #105: Update Brooklyn vagrant
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/105#discussion_r138851452
--- Diff: vagrant/src/main/vagrant/files/install_brooklyn.sh ---
@@ -48,45 +48,53 @@ fi
if [ ! "${INSTALL_FROM_LOCAL_DIST}" == "true" ]; then
if [ ! -z "${BROOKLYN_VERSION##*-SNAPSHOT}" ] ; then
# url for official release versions
- BROOKLYN_URL="https://www.apache.org/dyn/closer.lua?action=download&filename=brooklyn/apache-brooklyn-${BROOKLYN_VERSION}/apache-brooklyn-${BROOKLYN_VERSION}-bin.tar.gz"
- BROOKLYN_DIR="apache-brooklyn-${BROOKLYN_VERSION}-bin"
+ BROOKLYN_URL="https://www.apache.org/dyn/closer.lua?action=download&filename=brooklyn/apache-brooklyn-${BROOKLYN_VERSION}/apache-brooklyn-${BROOKLYN_VERSION}.noarch.rpm"
else
# url for community-managed snapshots
- BROOKLYN_URL="https://repository.apache.org/service/local/artifact/maven/redirect?r=snapshots&g=org.apache.brooklyn&a=brooklyn-dist&v=${BROOKLYN_VERSION}&c=dist&e=tar.gz"
- BROOKLYN_DIR="brooklyn-dist-${BROOKLYN_VERSION}"
+ BROOKLYN_URL="https://repository.apache.org/service/local/artifact/maven/redirect?r=snapshots&g=org.apache.brooklyn&a=rpm-packaging&v=${BROOKLYN_VERSION}&c=noarch&e=rpm"
--- End diff --
`rpm-packaging` seems to be available for [releases](https://repository.apache.org/content/groups/public/org/apache/brooklyn/rpm-packaging/) but not for [snapshots](https://repository.apache.org/content/groups/snapshots/org/apache/brooklyn/rpm-packaging/).
---
[GitHub] brooklyn-dist issue #105: Update Brooklyn vagrant to use RPM
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-dist/pull/105
DO NOT MERGE YET: This requires the DEB and RPM package to be available for SNAPSHOT version. In the meantime, #106 will do the trick to move to Karaf
---
[GitHub] brooklyn-dist pull request #105: Update Brooklyn vagrant
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/105#discussion_r138854462
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -38,7 +38,7 @@ default_config:
run_os_update: true
servers:
- name: brooklyn
- box: bento/centos-7.3
--- End diff --
Fair enough, I wasn't aware of this changes. I changed it because I always prefer the official images rather than 3rd party ones. I'll update
---
[GitHub] brooklyn-dist pull request #105: Update Brooklyn vagrant
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/105#discussion_r138848843
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -38,7 +38,7 @@ default_config:
run_os_update: true
servers:
- name: brooklyn
- box: bento/centos-7.3
--- End diff --
Why change back from bento boxes? the positive reasons for using them are in #86
---
[GitHub] brooklyn-dist pull request #105: Update Brooklyn vagrant
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/105#discussion_r138854297
--- Diff: vagrant/src/main/vagrant/files/install_brooklyn.sh ---
@@ -48,45 +48,53 @@ fi
if [ ! "${INSTALL_FROM_LOCAL_DIST}" == "true" ]; then
if [ ! -z "${BROOKLYN_VERSION##*-SNAPSHOT}" ] ; then
# url for official release versions
- BROOKLYN_URL="https://www.apache.org/dyn/closer.lua?action=download&filename=brooklyn/apache-brooklyn-${BROOKLYN_VERSION}/apache-brooklyn-${BROOKLYN_VERSION}-bin.tar.gz"
- BROOKLYN_DIR="apache-brooklyn-${BROOKLYN_VERSION}-bin"
+ BROOKLYN_URL="https://www.apache.org/dyn/closer.lua?action=download&filename=brooklyn/apache-brooklyn-${BROOKLYN_VERSION}/apache-brooklyn-${BROOKLYN_VERSION}.noarch.rpm"
else
# url for community-managed snapshots
- BROOKLYN_URL="https://repository.apache.org/service/local/artifact/maven/redirect?r=snapshots&g=org.apache.brooklyn&a=brooklyn-dist&v=${BROOKLYN_VERSION}&c=dist&e=tar.gz"
- BROOKLYN_DIR="brooklyn-dist-${BROOKLYN_VERSION}"
+ BROOKLYN_URL="https://repository.apache.org/service/local/artifact/maven/redirect?r=snapshots&g=org.apache.brooklyn&a=rpm-packaging&v=${BROOKLYN_VERSION}&c=noarch&e=rpm"
--- End diff --
Good catch! That's odd, the docs says the reverse. I think @richardcloudsoft is looking at building RPM and DEB for snapshot versions
---
[GitHub] brooklyn-dist issue #105: Update Brooklyn vagrant
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-dist/pull/105
retest this please
---