You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Alexander Kriegisch (Jira)" <ji...@apache.org> on 2021/07/03 02:53:00 UTC
[jira] [Comment Edited] (MSHADE-396) Improve SourceContent Shading
[ https://issues.apache.org/jira/browse/MSHADE-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373880#comment-17373880 ]
Alexander Kriegisch edited comment on MSHADE-396 at 7/3/21, 2:52 AM:
---------------------------------------------------------------------
[~Reamer], thanks for the notification. I am going to take a look as soon as I have some free cycles. Not being a committer in this project, my review is not authoritative, though. BTW, I am happy that someone uses my source shading implementation. It was heuristic to begin with - a perfect solution would require full Java parsing and probably some kind of source AST representation - and certainly has room for incremental improvement. This is the beauty of OSS development: There is always someone out there who can take your work one step further or sometimes even lift it to a whole new level. 🙂
was (Author: kriegaex):
[~Reamer], thanks for the notification. I am going to take a look as soon as I have some free cycles. Not being a committer in this project, my review is not authoritative, though. BTW, I am happy that someone uses my source shading implementation. It was heuristic to begin with - a perfect solution would require full Java parsing and probable some kind of source AST representation - and certainly has room for incremental improvement. This is the beauty of OSS development: There is always someone out there who can your work one step further or sometimes even lift it to a whole new level. 🙂
> Improve SourceContent Shading
> -----------------------------
>
> Key: MSHADE-396
> URL: https://issues.apache.org/jira/browse/MSHADE-396
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 3.2.4, 3.3.0
> Reporter: Philipp Dallig
> Priority: Major
>
> MSHADE-252 has greatly improved the shading of the source content. I used this version but found some problems in combination with a small pattern.
> Examples:
> We should exclude replacement in the following situations
> - Pattern: "io"
> Content: java.io.IOException;
> Content: private String myException;
> - Pattern: io
> Content: private String ioInput
> Content: String io, val;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)