You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "abderrahim (via GitHub)" <gi...@apache.org> on 2024/08/01 13:36:42 UTC
[PR] Ensure blobs are available when needed (when using storage-service) [buildstream]
abderrahim opened a new pull request, #1938:
URL: https://github.com/apache/buildstream/pull/1938
Fixes https://github.com/apache/buildstream/issues/1937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure blobs are available when needed (when using storage-service) [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi commented on code in PR #1938:
URL: https://github.com/apache/buildstream/pull/1938#discussion_r1701380309
##########
src/buildstream/storage/directory.py:
##########
@@ -466,6 +466,13 @@ def _import_files(
def _export_files(self, to_directory: str, *, can_link: bool = False, can_destroy: bool = False) -> None:
raise NotImplementedError()
+ # _ensure()
+ #
+ # Makes sure the files for the directory are available locally. Should be called before
+ # using _get_underlying_path()
+ def _ensure(self):
Review Comment:
Can we make the method name a bit clearer? Maybe `_ensure_local()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure blobs are available when needed (when using storage-service) [buildstream]
Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim merged PR #1938:
URL: https://github.com/apache/buildstream/pull/1938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ensure blobs are available when needed (when using storage-service) [buildstream]
Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on code in PR #1938:
URL: https://github.com/apache/buildstream/pull/1938#discussion_r1701547511
##########
src/buildstream/storage/directory.py:
##########
@@ -466,6 +466,13 @@ def _import_files(
def _export_files(self, to_directory: str, *, can_link: bool = False, can_destroy: bool = False) -> None:
raise NotImplementedError()
+ # _ensure()
+ #
+ # Makes sure the files for the directory are available locally. Should be called before
+ # using _get_underlying_path()
+ def _ensure(self):
Review Comment:
Sure. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org