You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/27 05:27:23 UTC

[GitHub] [trafficserver] tomoatan opened a new pull request #8180: Revert "Remove UnixNetVConnection::startEvent - not actually called."

tomoatan opened a new pull request #8180:
URL: https://github.com/apache/trafficserver/pull/8180


   Reverts #7609
   
   In #7609, UnixNetVConnection::startEvent was removed but it's necessary in UnixNetProcessor::connect_re_internal.
   In the following code, UnixNetVConnection is scheduled if some mutexes can't be locked.
   https://github.com/apache/trafficserver/blob/5a1697d23d200ce27f06abbe9aca394fb779ad60/iocore/net/UnixNetProcessor.cc#L275-L295
   
   In this case, UnixNetVConnection::startEvent is appropriate as a handler 
   because UnixNetVConnection is scheduled to execute UnixNetVConnection::connectUp.
   Before #7609, UnixNetVConnection::startEvent was set as a handler in constructor, so I revert it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 edited a comment on pull request #8180: Revert "Remove UnixNetVConnection::startEvent - not actually called."

Posted by GitBox <gi...@apache.org>.
masaori335 edited a comment on pull request #8180:
URL: https://github.com/apache/trafficserver/pull/8180#issuecomment-888076411


   @tomoatan Could you make another PR against the master branch? We can mark this PR as a backport PR of it when it's merged.
   Because, as a convention, we fix issues on the master branch and backport it to branches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 commented on pull request #8180: Revert "Remove UnixNetVConnection::startEvent - not actually called."

Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8180:
URL: https://github.com/apache/trafficserver/pull/8180#issuecomment-887891328


   FWIW, #7609 is the backport PR of #7596.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] tomoatan commented on pull request #8180: Revert "Remove UnixNetVConnection::startEvent - not actually called."

Posted by GitBox <gi...@apache.org>.
tomoatan commented on pull request #8180:
URL: https://github.com/apache/trafficserver/pull/8180#issuecomment-888040053


   @masaori335 
   > Do we have the same issue on the master branch?
   
   Yes, master branch has the same issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 commented on pull request #8180: Revert "Remove UnixNetVConnection::startEvent - not actually called."

Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8180:
URL: https://github.com/apache/trafficserver/pull/8180#issuecomment-887888516


   @tomoatan Thanks for the report. The revert seems reasonable at the first glance.
   Do we have the same issue on the master branch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 commented on pull request #8180: Revert "Remove UnixNetVConnection::startEvent - not actually called."

Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8180:
URL: https://github.com/apache/trafficserver/pull/8180#issuecomment-891413278


   Close this in favor of #8195 to backport #8184 to the 8.1.x branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 commented on pull request #8180: Revert "Remove UnixNetVConnection::startEvent - not actually called."

Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8180:
URL: https://github.com/apache/trafficserver/pull/8180#issuecomment-888076411


   @tomoatan Could you make another PR against the master branch? We can mark this PR as a backport PR of it when it's merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 commented on pull request #8180: Revert "Remove UnixNetVConnection::startEvent - not actually called."

Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8180:
URL: https://github.com/apache/trafficserver/pull/8180#issuecomment-887889743


   [approve ci]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] tomoatan commented on pull request #8180: Revert "Remove UnixNetVConnection::startEvent - not actually called."

Posted by GitBox <gi...@apache.org>.
tomoatan commented on pull request #8180:
URL: https://github.com/apache/trafficserver/pull/8180#issuecomment-888117262


   @masaori335 OK. I created PR #8182 against the master branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 closed pull request #8180: Revert "Remove UnixNetVConnection::startEvent - not actually called."

Posted by GitBox <gi...@apache.org>.
masaori335 closed pull request #8180:
URL: https://github.com/apache/trafficserver/pull/8180


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org