[GitHub] [spark] Yikun commented on pull request #35359: [SPARK-37713][K8S][FOLLOWUP] Fix insufficient namespace propagation

[GitBox <gi...@apache.org>]

Yikun commented on pull request #35359:
URL: https://github.com/apache/spark/pull/35359#issuecomment-1024814048


   @dongjoon-hyun Thanks ping me. 
   
   > I don't think that the verbose revert commit and redo commit is necessary.
   
   We only need to revert commit, **redo commit isn's necessary**, because we don't need to set metadata.namespace explictly. And the original issue [SPARK-37713](https://issues.apache.org/jira/browse/SPARK-37713) should be marked as invalid I guess.
   
   And also the [current namespace set way](https://github.com/apache/spark/blob/master/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientUtils.scala#L93) break a special case like below:
   ```
   apiVersion: v1
   kind: ConfigMap
   metadata:
     name: configmap
     # This is metadata.namespace, the namespace of configMap
     namespace:  
   data:
     # This is data.namespace, fill up in configFileMap, user want to add a namespace file
     namespace:
       foo=bar
   ```
   
   So, I still prefer to revert becasue It's unnecessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org