You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/12 18:37:35 UTC

[GitHub] [superset] bryanjtc opened a new issue, #21440: [SIP-88] Proposal for adding latin america countries to country map

bryanjtc opened a new issue, #21440:
URL: https://github.com/apache/superset/issues/21440

   *Please make sure you are familiar with the SIP process documented*
   (here)[https://github.com/apache/superset/issues/5602]. The SIP number should be the next number after the latest SIP listed [here](https://github.com/apache/superset/issues?q=is%3Aissue+label%3Asip).
   
   ## [SIP-88] Proposal for adding latin america countries to country map
   
   ### Motivation
   
   I'm working on a project where I need to visualise data from latin america countries, but there a lot of countries missing from the country map.
   
   ### Proposed Change
   
   I propose to add the following countries: argentina, bolivia, chile, colombia, costa rica, cuba, dominican republic, ecuador, el salvador, guatemala, haiti, honduras, nicaragua, panama, paraguay, puerto rico, saint barthelemy, saint martin and venezuela by using the guide detailed in this [documentation](https://superset.apache.org/docs/miscellaneous/country-map-tools/#adding-a-new-country).
   
   ### New or Changed Public Interfaces
   
   19 new countries are going to be added to the country map visualization tool
   
   ### New dependencies
   
   None
   
   ### Migration Plan and Compatibility
   
   None
   
   ### Rejected Alternatives
   
   None
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] betodealmeida commented on issue #21440: [SIP-89] Proposal for adding latin america countries to country map

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on issue #21440:
URL: https://github.com/apache/superset/issues/21440#issuecomment-1245577304

   > @betodealmeida Should I close this and open a new discussion? I already made a pr, I just need someone to review it. 
   
   Yeah, we can close and I can review the PR for you. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] betodealmeida commented on issue #21440: [SIP-89] Proposal for adding latin america countries to country map

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on issue #21440:
URL: https://github.com/apache/superset/issues/21440#issuecomment-1244767915

   We probably don't need a SIP for this, I think it's just an extension of an existing feature. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas closed issue #21440: [SIP-89] Proposal for adding latin america countries to country map

Posted by GitBox <gi...@apache.org>.
rusackas closed issue #21440: [SIP-89] Proposal for adding latin america countries to country map
URL: https://github.com/apache/superset/issues/21440


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] bryanjtc commented on issue #21440: [SIP-89] Proposal for adding latin america countries to country map

Posted by GitBox <gi...@apache.org>.
bryanjtc commented on issue #21440:
URL: https://github.com/apache/superset/issues/21440#issuecomment-1245488033

   @betodealmeida Should I close this and open a feature request issue? I already made a pr, I just need someone to review it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas commented on issue #21440: [SIP-89] Proposal for adding latin america countries to country map

Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #21440:
URL: https://github.com/apache/superset/issues/21440#issuecomment-1247495324

   Dropping a link to the PR [here](https://github.com/apache/superset/pull/21352). I added @betodealmeida as a reviewer there (and a couple others for good measure).
   
   Agreed, we can close this issue, and move on with development. Thank you for raising our awareness and for your contributions, @bryanjtc!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org