You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Yutian Li <ho...@gmail.com> on 2021/02/27 01:58:05 UTC
[PATCH] fix a comment in svn_fs_fs_private.h
[[[
Fix a comment in svn_fs_fs_private.h
* subversion/include/private/svn_fs_fs_private.h: Fix comment
]]]
Index: subversion/include/private/svn_fs_fs_private.h
===================================================================
--- subversion/include/private/svn_fs_fs_private.h (revision 1886964)
+++ subversion/include/private/svn_fs_fs_private.h (working copy)
@@ -272,7 +272,7 @@ typedef struct svn_fs_fs__id_part_t
svn_revnum_t revision;
/* sub-id value relative to REVISION. Its interpretation depends on
- the part itself. In rev_item, it is the index_index value, in others
+ the part itself. In rev_item, it is the item_index value, in others
it represents a unique counter value. */
apr_uint64_t number;
} svn_fs_fs__id_part_t;
Re: [PATCH] fix a comment in svn_fs_fs_private.h
Posted by Yutian Li <ho...@gmail.com>.
Great, thanks all!
On Thu, Mar 11, 2021 at 12:20 AM Karl Fogel <kf...@red-bean.com> wrote:
>
> On 09 Mar 2021, Daniel Shahaf wrote:
> >Thanks for the patch. dev@, anyone wants to review/apply this?
>
> r1887464, and thanks for the poke, Daniel.
>
> The original text was clearly a typo; I confirmed with some
> grepping and code exploration. Thanks for the patch, Yutian.
>
> Best regards, -Karl
>
> >Yutian Li wrote on Fri, Feb 26, 2021 at 20:58:05 -0500:
> >> [[[
> >> Fix a comment in svn_fs_fs_private.h
> >>
> >> * subversion/include/private/svn_fs_fs_private.h: Fix comment
> >> ]]]
> >>
> >> Index: subversion/include/private/svn_fs_fs_private.h
> >> ===================================================================
> >> --- subversion/include/private/svn_fs_fs_private.h (revision 1886964)
> >> +++ subversion/include/private/svn_fs_fs_private.h (working copy)
> >> @@ -272,7 +272,7 @@ typedef struct svn_fs_fs__id_part_t
> >> svn_revnum_t revision;
> >>
> >> /* sub-id value relative to REVISION. Its interpretation depends on
> >> - the part itself. In rev_item, it is the index_index value, in others
> >> + the part itself. In rev_item, it is the item_index value, in others
> >> it represents a unique counter value. */
> >> apr_uint64_t number;
> >> } svn_fs_fs__id_part_t;
Re: [PATCH] fix a comment in svn_fs_fs_private.h
Posted by Karl Fogel <kf...@red-bean.com>.
On 09 Mar 2021, Daniel Shahaf wrote:
>Thanks for the patch. dev@, anyone wants to review/apply this?
r1887464, and thanks for the poke, Daniel.
The original text was clearly a typo; I confirmed with some
grepping and code exploration. Thanks for the patch, Yutian.
Best regards, -Karl
>Yutian Li wrote on Fri, Feb 26, 2021 at 20:58:05 -0500:
>> [[[
>> Fix a comment in svn_fs_fs_private.h
>>
>> * subversion/include/private/svn_fs_fs_private.h: Fix comment
>> ]]]
>>
>> Index: subversion/include/private/svn_fs_fs_private.h
>> ===================================================================
>> --- subversion/include/private/svn_fs_fs_private.h (revision 1886964)
>> +++ subversion/include/private/svn_fs_fs_private.h (working copy)
>> @@ -272,7 +272,7 @@ typedef struct svn_fs_fs__id_part_t
>> svn_revnum_t revision;
>>
>> /* sub-id value relative to REVISION. Its interpretation depends on
>> - the part itself. In rev_item, it is the index_index value, in others
>> + the part itself. In rev_item, it is the item_index value, in others
>> it represents a unique counter value. */
>> apr_uint64_t number;
>> } svn_fs_fs__id_part_t;
Re: [PATCH] fix a comment in svn_fs_fs_private.h
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Thanks for the patch.
dev@, anyone wants to review/apply this?
Cheers,
Daniel
(looks like we need a patch manager again…)
Yutian Li wrote on Fri, Feb 26, 2021 at 20:58:05 -0500:
> [[[
> Fix a comment in svn_fs_fs_private.h
>
> * subversion/include/private/svn_fs_fs_private.h: Fix comment
> ]]]
>
> Index: subversion/include/private/svn_fs_fs_private.h
> ===================================================================
> --- subversion/include/private/svn_fs_fs_private.h (revision 1886964)
> +++ subversion/include/private/svn_fs_fs_private.h (working copy)
> @@ -272,7 +272,7 @@ typedef struct svn_fs_fs__id_part_t
> svn_revnum_t revision;
>
> /* sub-id value relative to REVISION. Its interpretation depends on
> - the part itself. In rev_item, it is the index_index value, in others
> + the part itself. In rev_item, it is the item_index value, in others
> it represents a unique counter value. */
> apr_uint64_t number;
> } svn_fs_fs__id_part_t;