You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/11/20 19:36:15 UTC

[GitHub] kkhatua commented on a change in pull request #1536: DRILL-6039: Fixed drillbit.sh script to do graceful shutdown

kkhatua commented on a change in pull request #1536: DRILL-6039: Fixed drillbit.sh script to do graceful shutdown
URL: https://github.com/apache/drill/pull/1536#discussion_r235138498
 
 

 ##########
 File path: distribution/src/resources/drillbit.sh
 ##########
 @@ -94,11 +94,24 @@ waitForProcessEnd()
   commandName=$2
   kill_drillbit=$3
   processedAt=`date +%s`
+  triggered_shutdown=false
+  FILE=$DRILL_PID_DIR/.graceful
 
 Review comment:
   I think making it hidden is practical, since this is only serves the purpose of signalling and is not expected to be around visible. 
   Also, @dvjyothsna , it might be worth changing the variable name to something like `GRACEFUL_SIGFILE`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services