You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/19 09:47:25 UTC
[GitHub] [arrow] vertexclique opened a new pull request #8713: ARROW-10653: [Rust] Update toolchain nightly
vertexclique opened a new pull request #8713:
URL: https://github.com/apache/arrow/pull/8713
I have deployed new intrinsics to rust lang core, so I want to bring these in iterations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8713: ARROW-10653: [Rust] Update toolchain nightly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8713:
URL: https://github.com/apache/arrow/pull/8713#issuecomment-730270987
https://issues.apache.org/jira/browse/ARROW-10653
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #8713: ARROW-10653: [Rust] Update toolchain nightly
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #8713:
URL: https://github.com/apache/arrow/pull/8713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8713: ARROW-10653: [Rust] Update toolchain nightly
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8713:
URL: https://github.com/apache/arrow/pull/8713#issuecomment-730564010
FYI @andygrove and @jorgecarleitao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8713: ARROW-10653: [Rust] Update toolchain nightly
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8713:
URL: https://github.com/apache/arrow/pull/8713#issuecomment-730563705
For the record: https://github.com/rust-lang/rust/pull/79131 perhaps is perhaps the change to rustlang that @vertexclique refers to
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vertexclique commented on pull request #8713: ARROW-10653: [Rust] Update toolchain nightly
Posted by GitBox <gi...@apache.org>.
vertexclique commented on pull request #8713:
URL: https://github.com/apache/arrow/pull/8713#issuecomment-730304017
r? @alamb @nevi-me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #8713: ARROW-10653: [Rust] Update toolchain nightly
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8713:
URL: https://github.com/apache/arrow/pull/8713#issuecomment-730264767
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8713?src=pr&el=h1) Report
> Merging [#8713](https://codecov.io/gh/apache/arrow/pull/8713?src=pr&el=desc) (e4c8e71) into [master](https://codecov.io/gh/apache/arrow/commit/256d0dc3f712154100aa6e0a610383b189008a83?el=desc) (256d0dc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow/pull/8713?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8713 +/- ##
==========================================
- Coverage 84.51% 84.50% -0.01%
==========================================
Files 177 177
Lines 43858 43861 +3
==========================================
- Hits 37067 37066 -1
- Misses 6791 6795 +4
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/8713?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/data\_type.rs](https://codecov.io/gh/apache/arrow/pull/8713/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9kYXRhX3R5cGUucnM=) | `84.61% <0.00%> (-1.17%)` | :arrow_down: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/8713/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `92.99% <0.00%> (-0.18%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/8713?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/8713?src=pr&el=footer). Last update [60ea0dc...e4c8e71](https://codecov.io/gh/apache/arrow/pull/8713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #8713: ARROW-10653: [Rust] Update toolchain nightly
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #8713:
URL: https://github.com/apache/arrow/pull/8713#issuecomment-730565436
Thanks a lot. LGTM. And as a side note: super cool @vertexclique that you are contributing to rust core! 😍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8713: ARROW-10653: [Rust] Update toolchain nightly
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8713:
URL: https://github.com/apache/arrow/pull/8713#issuecomment-730561357
This is cool -- though note I think there is a broader effort afoot to remove the use of rust nightly in Arrow (e.g. https://github.com/apache/arrow/pull/8698)
So I suspect that any use of stuff in nightly rust will likely have to be feature gated to make this work. Just something to keep in mind if you want to introduce more use of such intrinsics into the arrow crates
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org