You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/02/12 22:51:08 UTC

[jira] Created: (HBASE-442) Move internal classes out of HRegionServer

Move internal classes out of HRegionServer
------------------------------------------

                 Key: HBASE-442
                 URL: https://issues.apache.org/jira/browse/HBASE-442
             Project: Hadoop HBase
          Issue Type: Sub-task
            Reporter: Bryan Duxbury
            Assignee: Bryan Duxbury




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-442) Move internal classes out of HRegionServer

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated HBASE-442:
--------------------------------

    Status: Patch Available  (was: Open)

Review please.

> Move internal classes out of HRegionServer
> ------------------------------------------
>
>                 Key: HBASE-442
>                 URL: https://issues.apache.org/jira/browse/HBASE-442
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>         Attachments: 442.patch
>
>
>  * QueueEntry
>  * CompactSplitThread
>  * Flusher
>  * LogRoller
>  * Worker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-442) Move internal classes out of HRegionServer

Posted by "stack (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/HBASE-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572190#action_12572190 ] 

stack commented on HBASE-442:
-----------------------------

Can the LogRoller data members server and conf not also be final?  Same for 'private long expirationTime;' in QueueEntry.  Also some possibles in Flusher (even the lock could be final?  since it never changes).

This is a very nice clean up.  Fix above and commit.



> Move internal classes out of HRegionServer
> ------------------------------------------
>
>                 Key: HBASE-442
>                 URL: https://issues.apache.org/jira/browse/HBASE-442
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>         Attachments: 442.patch
>
>
>  * QueueEntry
>  * CompactSplitThread
>  * Flusher
>  * LogRoller
>  * Worker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-442) Move internal classes out of HRegionServer

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated HBASE-442:
--------------------------------

    Description: 
 * QueueEntry
 * CompactSplitThread
 * Flusher
 * LogRoller
 * Worker

> Move internal classes out of HRegionServer
> ------------------------------------------
>
>                 Key: HBASE-442
>                 URL: https://issues.apache.org/jira/browse/HBASE-442
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>
>  * QueueEntry
>  * CompactSplitThread
>  * Flusher
>  * LogRoller
>  * Worker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-442) Move internal classes out of HRegionServer

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman updated HBASE-442:
--------------------------------

        Fix Version/s: 0.2.0
    Affects Version/s: 0.2.0

> Move internal classes out of HRegionServer
> ------------------------------------------
>
>                 Key: HBASE-442
>                 URL: https://issues.apache.org/jira/browse/HBASE-442
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.2.0
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: 442.patch
>
>
>  * QueueEntry
>  * CompactSplitThread
>  * Flusher
>  * LogRoller
>  * Worker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-442) Move internal classes out of HRegionServer

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated HBASE-442:
--------------------------------

    Attachment: 442.patch

Here it is. Passes tests locally.

> Move internal classes out of HRegionServer
> ------------------------------------------
>
>                 Key: HBASE-442
>                 URL: https://issues.apache.org/jira/browse/HBASE-442
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>         Attachments: 442.patch
>
>
>  * QueueEntry
>  * CompactSplitThread
>  * Flusher
>  * LogRoller
>  * Worker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-442) Move internal classes out of HRegionServer

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated HBASE-442:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

QueueEntry has a setExpiration method so its member can't be final. I made the rest into finals.

Committed.

> Move internal classes out of HRegionServer
> ------------------------------------------
>
>                 Key: HBASE-442
>                 URL: https://issues.apache.org/jira/browse/HBASE-442
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>         Attachments: 442.patch
>
>
>  * QueueEntry
>  * CompactSplitThread
>  * Flusher
>  * LogRoller
>  * Worker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-442) Move internal classes out of HRegionServer

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/HBASE-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated HBASE-442:
--------------------------------

    Priority: Minor  (was: Major)

> Move internal classes out of HRegionServer
> ------------------------------------------
>
>                 Key: HBASE-442
>                 URL: https://issues.apache.org/jira/browse/HBASE-442
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>
>  * QueueEntry
>  * CompactSplitThread
>  * Flusher
>  * LogRoller
>  * Worker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.