You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/04/22 21:54:59 UTC
Review Request 20571: Replace sed command with linux and OSX-friendly perl
expression.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20571/
-----------------------------------------------------------
Review request for Aurora and Jake Farrell.
Repository: aurora
Description
-------
Replace sed command with linux and OSX-friendly perl expression.
Diffs
-----
examples/vagrant/test_tutorial.sh 1b745b817feffc955fd6fce34eeeb520663302fb
Diff: https://reviews.apache.org/r/20571/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 20571: Replace sed command with linux and OSX-friendly
perl expression.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20571/
-----------------------------------------------------------
(Updated April 22, 2014, 8:05 p.m.)
Review request for Aurora and Jake Farrell.
Bugs: AURORA-344
https://issues.apache.org/jira/browse/AURORA-344
Repository: aurora
Description
-------
Replace sed command with linux and OSX-friendly perl expression.
Some context discussion here: http://stackoverflow.com/questions/2320564/variations-of-sed-between-osx-and-gnu-linux
Diffs
-----
examples/vagrant/test_tutorial.sh 1b745b817feffc955fd6fce34eeeb520663302fb
Diff: https://reviews.apache.org/r/20571/diff/
Testing
-------
I can now successfully run this script on OS X 10.9 and Ubuntu 13.10.
Thanks,
Bill Farner
Re: Review Request 20571: Replace sed command with linux and OSX-friendly
perl expression.
Posted by Bill Farner <wf...@apache.org>.
> On April 22, 2014, 7:58 p.m., Jake Farrell wrote:
> > Whats the bug associated with this? other than that +1
Exercised judgement that the ticket felt like busywork. I think we still need to achieve consensus on what role we want tickets to play so that we can share a mental model for when they're needed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20571/#review41054
-----------------------------------------------------------
On April 22, 2014, 7:55 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20571/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 7:55 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Replace sed command with linux and OSX-friendly perl expression.
>
> Some context discussion here: http://stackoverflow.com/questions/2320564/variations-of-sed-between-osx-and-gnu-linux
>
>
> Diffs
> -----
>
> examples/vagrant/test_tutorial.sh 1b745b817feffc955fd6fce34eeeb520663302fb
>
> Diff: https://reviews.apache.org/r/20571/diff/
>
>
> Testing
> -------
>
> I can now successfully run this script on OS X 10.9 and Ubuntu 13.10.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 20571: Replace sed command with linux and OSX-friendly
perl expression.
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20571/#review41054
-----------------------------------------------------------
Ship it!
Whats the bug associated with this? other than that +1
- Jake Farrell
On April 22, 2014, 7:55 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20571/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 7:55 p.m.)
>
>
> Review request for Aurora and Jake Farrell.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Replace sed command with linux and OSX-friendly perl expression.
>
> Some context discussion here: http://stackoverflow.com/questions/2320564/variations-of-sed-between-osx-and-gnu-linux
>
>
> Diffs
> -----
>
> examples/vagrant/test_tutorial.sh 1b745b817feffc955fd6fce34eeeb520663302fb
>
> Diff: https://reviews.apache.org/r/20571/diff/
>
>
> Testing
> -------
>
> I can now successfully run this script on OS X 10.9 and Ubuntu 13.10.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 20571: Replace sed command with linux and OSX-friendly
perl expression.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20571/
-----------------------------------------------------------
(Updated April 22, 2014, 7:55 p.m.)
Review request for Aurora and Jake Farrell.
Repository: aurora
Description (updated)
-------
Replace sed command with linux and OSX-friendly perl expression.
Some context discussion here: http://stackoverflow.com/questions/2320564/variations-of-sed-between-osx-and-gnu-linux
Diffs
-----
examples/vagrant/test_tutorial.sh 1b745b817feffc955fd6fce34eeeb520663302fb
Diff: https://reviews.apache.org/r/20571/diff/
Testing
-------
I can now successfully run this script on OS X 10.9 and Ubuntu 13.10.
Thanks,
Bill Farner
Re: Review Request 20571: Replace sed command with linux and OSX-friendly
perl expression.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20571/
-----------------------------------------------------------
(Updated April 22, 2014, 7:55 p.m.)
Review request for Aurora and Jake Farrell.
Repository: aurora
Description
-------
Replace sed command with linux and OSX-friendly perl expression.
Diffs
-----
examples/vagrant/test_tutorial.sh 1b745b817feffc955fd6fce34eeeb520663302fb
Diff: https://reviews.apache.org/r/20571/diff/
Testing (updated)
-------
I can now successfully run this script on OS X 10.9 and Ubuntu 13.10.
Thanks,
Bill Farner