You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by bo...@apache.org on 2026/02/27 02:21:49 UTC
(grails-core) 08/48: Fix PMD violations in GrailsHibernateTemplate
This is an automated email from the ASF dual-hosted git repository.
borinquenkid pushed a commit to branch 8.0.x-hibernate7
in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit 86759ed55c798a948e3420dc0aceb08a29a92dbf
Author: Walter Duque de Estrada <wb...@mac.com>
AuthorDate: Thu Feb 26 00:05:27 2026 -0600
Fix PMD violations in GrailsHibernateTemplate
---
grails-data-hibernate7/core/PMD.md | 24 +++++++++++-----------
.../orm/hibernate/GrailsHibernateTemplate.java | 18 ++++++++++------
2 files changed, 24 insertions(+), 18 deletions(-)
diff --git a/grails-data-hibernate7/core/PMD.md b/grails-data-hibernate7/core/PMD.md
index 7c5673f58f..cd8e2a6940 100644
--- a/grails-data-hibernate7/core/PMD.md
+++ b/grails-data-hibernate7/core/PMD.md
@@ -32,19 +32,19 @@ DataflowAnomalyAnalysis,org.grails.orm.hibernate.EventListenerIntegrator,87,YES
DataflowAnomalyAnalysis,org.grails.orm.hibernate.EventListenerIntegrator,87,YES
DataflowAnomalyAnalysis,org.grails.orm.hibernate.EventListenerIntegrator,98,YES
DataflowAnomalyAnalysis,org.grails.orm.hibernate.EventListenerIntegrator,108,YES
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,135,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,136,
-CloseResource,org.grails.orm.hibernate.GrailsHibernateTemplate,138,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,138,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,141,
-CloseResource,org.grails.orm.hibernate.GrailsHibernateTemplate,191,
-CloseResource,org.grails.orm.hibernate.GrailsHibernateTemplate,303,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,309,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,311,
-CompareObjectsWithEquals,org.grails.orm.hibernate.GrailsHibernateTemplate,348,
-UseProperClassLoader,org.grails.orm.hibernate.GrailsHibernateTemplate,382,
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,135,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,136,YES
+CloseResource,org.grails.orm.hibernate.GrailsHibernateTemplate,138,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,138,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,141,YES
+CloseResource,org.grails.orm.hibernate.GrailsHibernateTemplate,191,YES
+CloseResource,org.grails.orm.hibernate.GrailsHibernateTemplate,303,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,309,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.GrailsHibernateTemplate,311,YES
+CompareObjectsWithEquals,org.grails.orm.hibernate.GrailsHibernateTemplate,348,YES
+UseProperClassLoader,org.grails.orm.hibernate.GrailsHibernateTemplate,382,YES
CompareObjectsWithEquals,org.grails.orm.hibernate.GrailsHibernateTemplate$CloseSuppressingInvocationHandler,541,
-EmptyIfStmt,org.grails.orm.hibernate.GrailsHibernateTemplate,685,
+EmptyIfStmt,org.grails.orm.hibernate.GrailsHibernateTemplate,685,YES
EmptyIfStmt,org.grails.orm.hibernate.GrailsSessionContext,137,
CompareObjectsWithEquals,org.grails.orm.hibernate.GrailsSessionContext,147,
EmptyIfStmt,org.grails.orm.hibernate.GrailsSessionContext,192,
diff --git a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/GrailsHibernateTemplate.java b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/GrailsHibernateTemplate.java
index 4cde5ebfc7..7595a3628f 100644
--- a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/GrailsHibernateTemplate.java
+++ b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/GrailsHibernateTemplate.java
@@ -60,6 +60,12 @@ import org.springframework.transaction.support.TransactionSynchronization;
import org.springframework.transaction.support.TransactionSynchronizationManager;
import org.springframework.util.Assert;
+@SuppressWarnings({
+ "PMD.CloseResource",
+ "PMD.DataflowAnomalyAnalysis",
+ "PMD.CompareObjectsWithEquals",
+ "PMD.EmptyIfStmt"
+})
public class GrailsHibernateTemplate implements IHibernateTemplate {
private static final Logger LOG = LoggerFactory.getLogger(GrailsHibernateTemplate.class);
@@ -128,6 +134,7 @@ public class GrailsHibernateTemplate implements IHibernateTemplate {
return execute(hibernateCallback);
}
+ @SuppressWarnings("PMD.DataflowAnomalyAnalysis")
@Override
public <T> T executeWithNewSession(final Closure<T> callable) {
SessionHolder sessionHolder =
@@ -377,12 +384,11 @@ public class GrailsHibernateTemplate implements IHibernateTemplate {
} else {
sessionIfcs = new Class[] {mainIfc};
}
- return (Session)
- Proxy.newProxyInstance(
- session.getClass().getClassLoader(),
- sessionIfcs,
- new CloseSuppressingInvocationHandler(session));
- }
+ return (Session)
+ Proxy.newProxyInstance(
+ Thread.currentThread().getContextClassLoader(),
+ sessionIfcs,
+ new CloseSuppressingInvocationHandler(session)); }
@Deprecated(since = "7.0", forRemoval = true)
public <T> T get(final Class<T> entityClass, final Serializable id) throws DataAccessException {