You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ghxandsky <gi...@git.apache.org> on 2015/12/09 17:59:58 UTC

[GitHub] cloudstack pull request: Fix vm cannot register and poweron on vce...

GitHub user ghxandsky opened a pull request:

    https://github.com/apache/cloudstack/pull/1203

    Fix vm cannot register and poweron on vcenter with vm.instancename.flag = 'true'

    In my lab, I run with CloudStack 4.4 + VMware vCenter 5.5.
    With vm.instancename.flag = 'true', the vm name on vcenter is as instancen ame. 
    I stop the vm and unregister it on vcenter, running startvm on CloudStack will fail. 
    However, it works well with vm.instancename.flag = 'false', the default value.
    I check the code and fix 'findVmOnHyperHost' should refere to vmNameOnVcenter, not vmInternalCSName.
    Finaly, it works. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ghxandsky/cloudstack VMware-Fix-2015-12-10

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1203
    
----
commit 16e0c5f18958f1dae42ea3074efae9411b5c8cfa
Author: 郭华星 <gu...@96900.com.cn>
Date:   2015-12-09T16:43:06Z

    Fix virtualmachine cannot register on VMware vCenter with vm.instancename.flag set 'true'.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix vm cannot register and poweron on vce...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:

    https://github.com/apache/cloudstack/pull/1203#issuecomment-216207807
  
    LGTM, not tested though
    
    @ghxandsky can you rebase against latest master and share state of your PR, thanks
    
    tag:vmware-pickup


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix vm cannot register and poweron on vce...

Posted by cristofolini <gi...@git.apache.org>.
Github user cristofolini commented on the pull request:

    https://github.com/apache/cloudstack/pull/1203#issuecomment-186820477
  
    @ghxandsky Would you please go ahead and rebase this PR against the current master? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---