You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Harsh J (Created) (JIRA)" <ji...@apache.org> on 2012/01/09 04:15:41 UTC
[jira] [Created] (HADOOP-7966) Add back in the older -getmerge
addnl param and add a test case for the new -nl param.
Add back in the older -getmerge addnl param and add a test case for the new -nl param.
--------------------------------------------------------------------------------------
Key: HADOOP-7966
URL: https://issues.apache.org/jira/browse/HADOOP-7966
Project: Hadoop Common
Issue Type: Sub-task
Affects Versions: 0.24.0
Reporter: Harsh J
Assignee: Harsh J
This is to fix Eli's comments on the parent task:
bq. This breaks a public API, why not preserve it but add in the improved one and update the docs to refer to it? Also, the test for this (HDFS-2070) should be done before the change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7966) Add back in the older -getmerge
addnl param and add a test case for the new -nl param.
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182710#comment-13182710 ]
Daryn Sharp commented on HADOOP-7966:
-------------------------------------
My thoughts are the redesign of {{FsShell}} introduced some incompatibilities, and the getmerge change is a rather small change that further improves the inconsistency of the shell commands. That said, I won't block making it backwards compat, but I think a deprecated warning should be emitted. Although a warning may introduce incompatibility if the calling script is checking stderr...
> Add back in the older -getmerge addnl param and add a test case for the new -nl param.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-7966
> URL: https://issues.apache.org/jira/browse/HADOOP-7966
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
>
> This is to fix Eli's comments on the parent task:
> bq. This breaks a public API, why not preserve it but add in the improved one and update the docs to refer to it? Also, the test for this (HDFS-2070) should be done before the change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7966) Add back in the older -getmerge
addnl param and add a test case for the new -nl param.
Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7966:
--------------------------------
Attachment: Grid_FsShellImpact.pdf
> Add back in the older -getmerge addnl param and add a test case for the new -nl param.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-7966
> URL: https://issues.apache.org/jira/browse/HADOOP-7966
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: Grid_FsShellImpact.pdf
>
>
> This is to fix Eli's comments on the parent task:
> bq. This breaks a public API, why not preserve it but add in the improved one and update the docs to refer to it? Also, the test for this (HDFS-2070) should be done before the change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7966) Add back in the older -getmerge
addnl param and add a test case for the new -nl param.
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182763#comment-13182763 ]
Daryn Sharp commented on HADOOP-7966:
-------------------------------------
The incompatibilities should have been listed in the respective jiras, but I'll attach a doc with a summary of the known impact.
> Add back in the older -getmerge addnl param and add a test case for the new -nl param.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-7966
> URL: https://issues.apache.org/jira/browse/HADOOP-7966
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: Grid_FsShellImpact.pdf
>
>
> This is to fix Eli's comments on the parent task:
> bq. This breaks a public API, why not preserve it but add in the improved one and update the docs to refer to it? Also, the test for this (HDFS-2070) should be done before the change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7966) Add back in the older -getmerge
addnl param and add a test case for the new -nl param.
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182639#comment-13182639 ]
Daryn Sharp commented on HADOOP-7966:
-------------------------------------
I'm not sure I agree with adding back the old behavior. It used what should have been a path argument to decide if newlines should be added. That behavior is inconsistent with all other commands.
> Add back in the older -getmerge addnl param and add a test case for the new -nl param.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-7966
> URL: https://issues.apache.org/jira/browse/HADOOP-7966
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
>
> This is to fix Eli's comments on the parent task:
> bq. This breaks a public API, why not preserve it but add in the improved one and update the docs to refer to it? Also, the test for this (HDFS-2070) should be done before the change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HADOOP-7966) Add back in the older
-getmerge addnl param and add a test case for the new -nl param.
Posted by "Eli Collins (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182699#comment-13182699 ]
Eli Collins edited comment on HADOOP-7966 at 1/9/12 6:42 PM:
-------------------------------------------------------------
Why is it OK to break existing Hadoop scripts w/o at least first deprecating the option?
was (Author: eli):
Why is it OK to break existing Hadoop scripts?
> Add back in the older -getmerge addnl param and add a test case for the new -nl param.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-7966
> URL: https://issues.apache.org/jira/browse/HADOOP-7966
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
>
> This is to fix Eli's comments on the parent task:
> bq. This breaks a public API, why not preserve it but add in the improved one and update the docs to refer to it? Also, the test for this (HDFS-2070) should be done before the change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7966) Add back in the older -getmerge
addnl param and add a test case for the new -nl param.
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182717#comment-13182717 ]
Eli Collins commented on HADOOP-7966:
-------------------------------------
What incompatibilities did the FsShell redesign introduce? At the least we should document them.
> Add back in the older -getmerge addnl param and add a test case for the new -nl param.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-7966
> URL: https://issues.apache.org/jira/browse/HADOOP-7966
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
>
> This is to fix Eli's comments on the parent task:
> bq. This breaks a public API, why not preserve it but add in the improved one and update the docs to refer to it? Also, the test for this (HDFS-2070) should be done before the change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-7966) Add back in the older -getmerge
addnl param and add a test case for the new -nl param.
Posted by "Eli Collins (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins resolved HADOOP-7966.
---------------------------------
Resolution: Not A Problem
Thanks Daryn, read your doc, and agree we're already incompat so this should be harmless (the new shell work is nice too btw!).
> Add back in the older -getmerge addnl param and add a test case for the new -nl param.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-7966
> URL: https://issues.apache.org/jira/browse/HADOOP-7966
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: Grid_FsShellImpact.pdf
>
>
> This is to fix Eli's comments on the parent task:
> bq. This breaks a public API, why not preserve it but add in the improved one and update the docs to refer to it? Also, the test for this (HDFS-2070) should be done before the change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7966) Add back in the older -getmerge
addnl param and add a test case for the new -nl param.
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182699#comment-13182699 ]
Eli Collins commented on HADOOP-7966:
-------------------------------------
Why is it OK to break existing Hadoop scripts?
> Add back in the older -getmerge addnl param and add a test case for the new -nl param.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-7966
> URL: https://issues.apache.org/jira/browse/HADOOP-7966
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
>
> This is to fix Eli's comments on the parent task:
> bq. This breaks a public API, why not preserve it but add in the improved one and update the docs to refer to it? Also, the test for this (HDFS-2070) should be done before the change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7966) Add back in the older -getmerge
addnl param and add a test case for the new -nl param.
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-7966:
----------------------------
Fix Version/s: (was: 0.24.0)
> Add back in the older -getmerge addnl param and add a test case for the new -nl param.
> --------------------------------------------------------------------------------------
>
> Key: HADOOP-7966
> URL: https://issues.apache.org/jira/browse/HADOOP-7966
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 0.24.0
> Reporter: Harsh J
> Assignee: Harsh J
>
> This is to fix Eli's comments on the parent task:
> bq. This breaks a public API, why not preserve it but add in the improved one and update the docs to refer to it? Also, the test for this (HDFS-2070) should be done before the change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira