[GitHub] [apisix] ShiningRush commented on a change in pull request #2271: fix: avoid overwriting Vary header in cors plugin

[GitBox <gi...@apache.org>]

ShiningRush commented on a change in pull request #2271:
URL: https://github.com/apache/apisix/pull/2271#discussion_r493227848



##########
File path: apisix/core/response.lua
##########
@@ -110,6 +116,31 @@ function _M.set_header(...)
 end
 
 
+function _M.add_header(...)

Review comment:
       `add_header` is almost same with `set_header`, we should extract common logic to avoid repeat code.

##########
File path: t/lib/server.lua
##########
@@ -269,6 +278,7 @@ function _M.go()
         return ngx.exit(404)
     end
 
+    inject_headers()

Review comment:
       Why we need change header key `resp-x` header to "x"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org