You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/01/12 13:08:04 UTC
Review Request 74277: RANGER-4016 : Add row draggable feature for policy Item table in policy form in react UI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74277/
-----------------------------------------------------------
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4016
https://issues.apache.org/jira/browse/RANGER-4016
Repository: ranger
Description
-------
Provide a row drag feature for reordering policy items in policy form.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105
security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js 9dbea93e6
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx c06b14021
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx ac01efd1d
security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx 3c83b509e
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx ddbb7bfc2
Diff: https://reviews.apache.org/r/74277/diff/1/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes .
2)Verified the row drag feature for reordering the policy items tables in Access, Masking and Row level Policy Forms.
3)Verified the CRUD Operation and validation for the Policy Forms.
Thanks,
Brijesh Bhalala
Re: Review Request 74277: RANGER-4016 : Add row draggable feature for policy Item table in policy form in react UI.
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74277/#review225140
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Rajpara
On Jan. 23, 2023, 1:47 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74277/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2023, 1:47 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4016
> https://issues.apache.org/jira/browse/RANGER-4016
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Provide a row drag feature for reordering policy items in policy form.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js 9dbea93e6
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx c06b14021
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx ac01efd1d
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx 3c83b509e
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx ddbb7bfc2
>
>
> Diff: https://reviews.apache.org/r/74277/diff/2/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes .
> 2)Verified the row drag feature for reordering the policy items tables in Access, Masking and Row level Policy Forms.
> 3)Verified the CRUD Operation and validation for the Policy Forms.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74277: RANGER-4016 : Add row draggable feature for policy Item table in policy form in react UI.
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74277/#review225144
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On Jan. 23, 2023, 1:47 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74277/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2023, 1:47 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4016
> https://issues.apache.org/jira/browse/RANGER-4016
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Provide a row drag feature for reordering policy items in policy form.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js 9dbea93e6
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx c06b14021
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx ac01efd1d
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx 3c83b509e
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx ddbb7bfc2
>
>
> Diff: https://reviews.apache.org/r/74277/diff/2/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes .
> 2)Verified the row drag feature for reordering the policy items tables in Access, Masking and Row level Policy Forms.
> 3)Verified the CRUD Operation and validation for the Policy Forms.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74277: RANGER-4016 : Add row draggable feature for policy Item table in policy form in react UI.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74277/#review225142
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Jan. 23, 2023, 1:47 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74277/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2023, 1:47 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4016
> https://issues.apache.org/jira/browse/RANGER-4016
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Provide a row drag feature for reordering policy items in policy form.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js 9dbea93e6
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx c06b14021
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx ac01efd1d
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx 3c83b509e
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx ddbb7bfc2
>
>
> Diff: https://reviews.apache.org/r/74277/diff/2/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes .
> 2)Verified the row drag feature for reordering the policy items tables in Access, Masking and Row level Policy Forms.
> 3)Verified the CRUD Operation and validation for the Policy Forms.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74277: RANGER-4016 : Add row draggable feature for policy Item table in policy form in react UI.
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74277/
-----------------------------------------------------------
(Updated Feb. 6, 2023, 6:51 a.m.)
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4016
https://issues.apache.org/jira/browse/RANGER-4016
Repository: ranger
Description
-------
Provide a row drag feature for reordering policy items in policy form.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105
security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js 9dbea93e6
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx c06b14021
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx ac01efd1d
security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx 3c83b509e
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx ddbb7bfc2
Diff: https://reviews.apache.org/r/74277/diff/2/
Testing (updated)
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the row drag feature for reordering the policy items tables in Access, Masking and Row level Policy Forms.
3)Verified the CRUD Operation and validation for the Policy Forms.
Thanks,
Brijesh Bhalala
Re: Review Request 74277: RANGER-4016 : Add row draggable feature for policy Item table in policy form in react UI.
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74277/
-----------------------------------------------------------
(Updated Jan. 23, 2023, 1:47 p.m.)
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4016
https://issues.apache.org/jira/browse/RANGER-4016
Repository: ranger
Description
-------
Provide a row drag feature for reordering policy items in policy form.
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105
security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js 9dbea93e6
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx c06b14021
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx ac01efd1d
security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx 3c83b509e
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx ddbb7bfc2
Diff: https://reviews.apache.org/r/74277/diff/2/
Changes: https://reviews.apache.org/r/74277/diff/1-2/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes .
2)Verified the row drag feature for reordering the policy items tables in Access, Masking and Row level Policy Forms.
3)Verified the CRUD Operation and validation for the Policy Forms.
Thanks,
Brijesh Bhalala
Re: Review Request 74277: RANGER-4016 : Add row draggable feature for policy Item table in policy form in react UI.
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74277/#review225102
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On Jan. 12, 2023, 1:08 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74277/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2023, 1:08 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4016
> https://issues.apache.org/jira/browse/RANGER-4016
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Provide a row drag feature for reordering policy items in policy form.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105
> security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js 9dbea93e6
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx c06b14021
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx ac01efd1d
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx 3c83b509e
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx ddbb7bfc2
>
>
> Diff: https://reviews.apache.org/r/74277/diff/1/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes .
> 2)Verified the row drag feature for reordering the policy items tables in Access, Masking and Row level Policy Forms.
> 3)Verified the CRUD Operation and validation for the Policy Forms.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>