You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "eschutho (via GitHub)" <gi...@apache.org> on 2023/03/01 01:02:35 UTC
[GitHub] [superset] eschutho opened a new pull request, #23244: chore: add full uuid to report crud view
eschutho opened a new pull request, #23244:
URL: https://github.com/apache/superset/pull/23244
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Small change to print the entire uuid on the alert/report execution logs when using the id to cross-check in system logs
### BEFORE
### AFTER
### TESTING INSTRUCTIONS
View execution logs for alerts or reports
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23244: chore: add full uuid to report crud view
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23244:
URL: https://github.com/apache/superset/pull/23244#issuecomment-1592111710
@eschutho Ephemeral environment spinning up at http://35.87.178.106:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: add full uuid to report crud view [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23244:
URL: https://github.com/apache/superset/pull/23244#issuecomment-2297861003
Heya! I'm just auditing some PRs that haven't been touched in a long time. Do we still want to get this one in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23244: chore: add full uuid to report crud view
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23244:
URL: https://github.com/apache/superset/pull/23244#issuecomment-1449194844
# [Codecov](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23244](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (88dcd12) into [master](https://codecov.io/gh/apache/superset/commit/9a4839f45c6d9a2cae89f5c77b434910be129f48?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9a4839f) will **decrease** coverage by `0.01%`.
> The diff coverage is `61.36%`.
> :exclamation: Current head 88dcd12 differs from pull request most recent head 62566f5. Consider uploading reports for the commit 62566f5 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23244 +/- ##
==========================================
- Coverage 67.50% 67.49% -0.01%
==========================================
Files 1898 1906 +8
Lines 72978 73415 +437
Branches 7899 7957 +58
==========================================
+ Hits 49262 49555 +293
- Misses 21691 21820 +129
- Partials 2025 2040 +15
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.73% <50.39%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/components/Table/VirtualTable.tsx](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGUvVmlydHVhbFRhYmxlLnRzeA==) | `72.30% <0.00%> (-1.13%)` | :arrow_down: |
| [...ard/components/FiltersBadge/DetailsPanel/index.tsx](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwvaW5kZXgudHN4) | `82.22% <ø> (ø)` | |
| [.../components/FiltersBadge/FilterIndicator/index.tsx](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9GaWx0ZXJJbmRpY2F0b3IvaW5kZXgudHN4) | `87.50% <ø> (ø)` | |
| [...nd/src/dashboard/components/FiltersBadge/index.tsx](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9pbmRleC50c3g=) | `86.11% <0.00%> (ø)` | |
| [...Filters/FilterBar/FilterControls/FilterControl.tsx](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2wudHN4) | `28.57% <ø> (ø)` | |
| [...veFilters/FilterBar/FilterControls/FilterValue.tsx](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlclZhbHVlLnRzeA==) | `5.71% <0.00%> (-0.29%)` | :arrow_down: |
| [...Filters/FilterBar/FiltersDropdownContent/index.tsx](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlcnNEcm9wZG93bkNvbnRlbnQvaW5kZXgudHN4) | `20.00% <0.00%> (-5.00%)` | :arrow_down: |
| [...s/FilterBar/FiltersOutOfScopeCollapsible/index.tsx](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlcnNPdXRPZlNjb3BlQ29sbGFwc2libGUvaW5kZXgudHN4) | `16.66% <0.00%> (-3.34%)` | :arrow_down: |
| [...board/components/nativeFilters/FilterBar/index.tsx](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL2luZGV4LnRzeA==) | `50.00% <ø> (ø)` | |
| [...ativeFilters/FilterBar/useFilterControlFactory.tsx](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL3VzZUZpbHRlckNvbnRyb2xGYWN0b3J5LnRzeA==) | `81.81% <ø> (ø)` | |
| ... and [63 more](https://codecov.io/gh/apache/superset/pull/23244?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #23244: chore: add full uuid to report crud view
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #23244:
URL: https://github.com/apache/superset/pull/23244#issuecomment-1461127873
@kasiazjc what do you think about the styling on this page?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: add full uuid to report crud view [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23244:
URL: https://github.com/apache/superset/pull/23244#issuecomment-2819893157
This one hasn't seen any activity in quite a long time, so I'll convert it to draft. Feel free to mark it ready for review when it's rebased, but it might eventually be closed due to inactivity otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: add full uuid to report crud view [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #23244:
URL: https://github.com/apache/superset/pull/23244#discussion_r1724135790
##########
superset-frontend/src/pages/ExecutionLogList/index.tsx:
##########
@@ -103,10 +103,18 @@ function ExecutionLog({ addDangerToast, isReportEnabled }: ExecutionLogProps) {
row: {
original: { uuid: executionId },
},
- }: any) => (executionId ? executionId.slice(0, 6) : 'none'),
+ }: any) => (
+ <div
Review Comment:
[optional] this might look cute as an antd <Label>, could also add a monospace bool prop (default false) to the component
##########
superset-frontend/src/pages/ExecutionLogList/index.tsx:
##########
@@ -103,10 +103,18 @@ function ExecutionLog({ addDangerToast, isReportEnabled }: ExecutionLogProps) {
row: {
original: { uuid: executionId },
},
- }: any) => (executionId ? executionId.slice(0, 6) : 'none'),
+ }: any) => (
+ <div
Review Comment:
[optional] this might look cute as an antd `<Label>`, could also add a monospace bool prop (default false) to the component
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: add full uuid to report crud view [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho closed pull request #23244: chore: add full uuid to report crud view
URL: https://github.com/apache/superset/pull/23244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #23244: chore: add full uuid to report crud view
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #23244:
URL: https://github.com/apache/superset/pull/23244#issuecomment-1592110131
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #23244: chore: add full uuid to report crud view
Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc commented on PR #23244:
URL: https://github.com/apache/superset/pull/23244#issuecomment-1462152529
> @kasiazjc what do you think about the styling on this page?
Seems to match other table based pages, I think we could fix some of the spacings/margins, but it would be another project for all of the CRUD view style pages. I have a few things to consider/check though:
- I think we might be missing left padding in the header (might be a screenshot problem)
- I think we could also replace the header with the global header component that we use in chart builder and dashboards. Then we do not have to worry about styling + we could add "more" or some kind of "settings" button on the right of the header to make it easier to edit the properties of the report. Need @yousoph opinion though as I am not that familiar with this part of our product. Would it even be useful?
- We do not use "back to all" button logic anywhere in the app as far as I'm aware . If this works well with all of the browser back buttons we can get rid of the one implemented.
I'm trying to figure out if there is a way to better communicate the type of of the object we are browsing. I think we could use metadata bar in header with first entry being "type=report". Adding a quick mock below. Not sure what other info could be included though than owner, description (I think there is one)? Maybe schedule?
<img width="1243" alt="image" src="https://user-images.githubusercontent.com/36897697/224053803-981da4e0-5b43-4e42-9a49-f298d2202f39.png">
(do not mind the table, this is random one from the mock I found)
Turns out it's a lot of ideas, @yousoph @eschutho need your opinion on what we can/want/don't want to do here right now. From my perspective using global header, removing back to all and adding a way to access report settings modal (if that makes sense) from this page would be a way to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org