You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailom-db (via GitHub)" <gi...@apache.org> on 2024/06/11 18:54:06 UTC

[PR] [WIP][SPARK-48572] Fix DateSub, DateAdd, WindowTime, TimeWindow and SessionWindow expressions [spark]

mihailom-db opened a new pull request, #46943:
URL: https://github.com/apache/spark/pull/46943

   ### What changes were proposed in this pull request?
   Fix for listed expressions.
   
   ### Why are the changes needed?
   These expressions are found to be faulty when working with collations.
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes, it fixes expressions that are not working with collations.
   
   
   ### How was this patch tested?
   Tests added for expressions to reproduce errors.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-48572][SQL] Fix DateSub, DateAdd, WindowTime, TimeWindow and SessionWindow expressions [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #46943: [SPARK-48572][SQL] Fix DateSub, DateAdd, WindowTime, TimeWindow and SessionWindow expressions
URL: https://github.com/apache/spark/pull/46943


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [WIP][SPARK-48572] Fix DateSub, DateAdd, WindowTime, TimeWindow and SessionWindow expressions [spark]

Posted by "uros-db (via GitHub)" <gi...@apache.org>.
uros-db commented on PR #46943:
URL: https://github.com/apache/spark/pull/46943#issuecomment-2167617775

   btw, should we add some tests for these changes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-48572][SQL] Fix DateSub, DateAdd, WindowTime, TimeWindow and SessionWindow expressions [spark]

Posted by "mihailom-db (via GitHub)" <gi...@apache.org>.
mihailom-db commented on PR #46943:
URL: https://github.com/apache/spark/pull/46943#issuecomment-2172608976

   @cloud-fan could you review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [WIP][SPARK-48572] Fix DateSub, DateAdd, WindowTime, TimeWindow and SessionWindow expressions [spark]

Posted by "mihailom-db (via GitHub)" <gi...@apache.org>.
mihailom-db commented on PR #46943:
URL: https://github.com/apache/spark/pull/46943#issuecomment-2168105684

   Will add them a bit later and will remove WIP when it is done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [WIP][SPARK-48572] Fix DateSub, DateAdd, WindowTime, TimeWindow and SessionWindow expressions [spark]

Posted by "uros-db (via GitHub)" <gi...@apache.org>.
uros-db commented on code in PR #46943:
URL: https://github.com/apache/spark/pull/46943#discussion_r1639536169


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala:
##########


Review Comment:
   note: I wanted to eventually cover this in https://github.com/apache/spark/pull/46659, but I'll close that now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-48572][SQL] Fix DateSub, DateAdd, WindowTime, TimeWindow and SessionWindow expressions [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #46943:
URL: https://github.com/apache/spark/pull/46943#issuecomment-2172700794

   thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org