You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "qidaye (via GitHub)" <gi...@apache.org> on 2023/03/01 06:36:08 UTC
[GitHub] [doris] qidaye commented on a diff in pull request #17276: [fix](inverted index) fix BE coredump because of not ignore case ensitivity for column name when create index
qidaye commented on code in PR #17276:
URL: https://github.com/apache/doris/pull/17276#discussion_r1121213356
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/IndexDef.java:
##########
@@ -34,6 +35,7 @@ public class IndexDef {
private String indexName;
private boolean ifNotExists;
private List<String> columns;
+ private List<String> caseSensitivityColumns = Lists.newArrayList();
Review Comment:
Please add some comments for the purpose.
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -2166,7 +2167,8 @@ private boolean processAddIndex(CreateIndexClause alterClause, OlapTable olapTab
}
}
- newIndexes.add(alterClause.getIndex());
+ alterIndex.setColumns(indexDef.getColumns());
Review Comment:
Add some comments .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org