You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ben-harris-5 (via GitHub)" <gi...@apache.org> on 2024/03/22 16:34:08 UTC
[PR] Use `outputVar` instead of hard coding `this.output` in JS codegen [thrift]
ben-harris-5 opened a new pull request, #2950:
URL: https://github.com/apache/thrift/pull/2950
<!-- Explain the changes in the pull request below: -->
When generating the JS Thrift clients, it hard-codes `this.output` in a few places; however, if `gen_node_` is true, our variable should be `output` instead. We set a variable, `outputVar`, up on line 1968/1970 of the file, but don't use it everywhere. In NodeJS environment, this can lead to the wrong flush being called, which can lead to issues; for example, with the header transport protocol, the headers can either go missing or be sent incorrectly.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
I believe this is a trivial change not requiring a ticket.
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
- [ ] ~If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?~
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] ~If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.~
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `outputVar` instead of hard coding `this.output` in JS codegen [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G closed pull request #2950: Use `outputVar` instead of hard coding `this.output` in JS codegen
URL: https://github.com/apache/thrift/pull/2950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `outputVar` instead of hard coding `this.output` in JS codegen [thrift]
Posted by "fishy (via GitHub)" <gi...@apache.org>.
fishy commented on PR #2950:
URL: https://github.com/apache/thrift/pull/2950#issuecomment-2075972715
Please:
1. Create a JIRA ticket to describe the issue (with what's the current generated code and what should be the correct code)
2. Resolve the merge conflicts (java failing should be fixed on latest master version)
3. Create an unit test under `lib/nodejs/test/` (or maybe `lib/js/test/`?) to verify this fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `outputVar` instead of hard coding `this.output` in JS codegen [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #2950:
URL: https://github.com/apache/thrift/pull/2950#issuecomment-3560217685
Rebase needed, no actvity since 2024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use `outputVar` instead of hard coding `this.output` in JS codegen [thrift]
Posted by "ben-harris-5 (via GitHub)" <gi...@apache.org>.
ben-harris-5 commented on PR #2950:
URL: https://github.com/apache/thrift/pull/2950#issuecomment-2015710787
CI is failing for this, but I'm incredibly unsure why or what's going wrong here. I'd greatly appreciate any assistance that folks could provide on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org