You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/28 21:34:34 UTC
[GitHub] [incubator-nuttx] davids5 opened a new pull request #5370: stm32:Add OTG ID GPIO disable
davids5 opened a new pull request #5370:
URL: https://github.com/apache/incubator-nuttx/pull/5370
## Summary
Allows one to Disables/Enabled the use of GPIO_OTG_ID pin. This allows non OTG use
cases to reuse this GPIO pin and ensure it is not set incorrectly during OS boot.
## Impact
none - behind a Knob
## Testing
PX4 Matek GPS (STM32F405RG)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #5370: stm32:Add OTG ID GPIO disable
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #5370:
URL: https://github.com/apache/incubator-nuttx/pull/5370#discussion_r795055083
##########
File path: arch/arm/src/stm32/Kconfig
##########
@@ -10828,6 +10828,19 @@ endmenu
comment "USB Device Configuration"
+menu "OTG Configuration"
+ depends on STM32_OTGFS
+
+config OTG_ID_GPIO_DISABLE
+ bool "Disable the use of GPIO_OTG_ID pin."
+ default n
+ ---help---
+ Disables/Enabled the use of GPIO_OTG_ID pin. This allows non OTG use
Review comment:
@acassis See https://github.com/apache/incubator-nuttx/pull/5372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5370: stm32:Add OTG ID GPIO disable
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5370:
URL: https://github.com/apache/incubator-nuttx/pull/5370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #5370: stm32:Add OTG ID GPIO disable
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #5370:
URL: https://github.com/apache/incubator-nuttx/pull/5370#discussion_r795054516
##########
File path: arch/arm/src/stm32/Kconfig
##########
@@ -10828,6 +10828,19 @@ endmenu
comment "USB Device Configuration"
+menu "OTG Configuration"
+ depends on STM32_OTGFS
+
+config OTG_ID_GPIO_DISABLE
+ bool "Disable the use of GPIO_OTG_ID pin."
+ default n
+ ---help---
+ Disables/Enabled the use of GPIO_OTG_ID pin. This allows non OTG use
Review comment:
@acassis - thanks fixed herein. Another PR is coming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5370: stm32:Add OTG ID GPIO disable
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5370:
URL: https://github.com/apache/incubator-nuttx/pull/5370#discussion_r794938325
##########
File path: arch/arm/src/stm32/Kconfig
##########
@@ -10828,6 +10828,19 @@ endmenu
comment "USB Device Configuration"
+menu "OTG Configuration"
+ depends on STM32_OTGFS
+
+config OTG_ID_GPIO_DISABLE
+ bool "Disable the use of GPIO_OTG_ID pin."
+ default n
+ ---help---
+ Disables/Enabled the use of GPIO_OTG_ID pin. This allows non OTG use
Review comment:
```suggestion
Disables/Enables the use of GPIO_OTG_ID pin. This allows non OTG use
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #5370: stm32:Add OTG ID GPIO disable
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #5370:
URL: https://github.com/apache/incubator-nuttx/pull/5370#discussion_r795054516
##########
File path: arch/arm/src/stm32/Kconfig
##########
@@ -10828,6 +10828,19 @@ endmenu
comment "USB Device Configuration"
+menu "OTG Configuration"
+ depends on STM32_OTGFS
+
+config OTG_ID_GPIO_DISABLE
+ bool "Disable the use of GPIO_OTG_ID pin."
+ default n
+ ---help---
+ Disables/Enabled the use of GPIO_OTG_ID pin. This allows non OTG use
Review comment:
@acassis - thanks. Another PR is coming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org