You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by paulo-raca <gi...@git.apache.org> on 2016/07/13 13:46:41 UTC
[GitHub] lucene-solr pull request #51: SOLR-9303: Refactor CloudSolrClient for extens...
GitHub user paulo-raca opened a pull request:
https://github.com/apache/lucene-solr/pull/51
SOLR-9303: Refactor CloudSolrClient for extensibility
I'm using a custom Solr plugins which adds extra constraints on which nodes I can access.
To respect these constraints, I needed to use a customized version of CloudSolrClient.
Unfortunately, CloudSolrClient.sendRequest() is currently written as one big chunk of code, breaking OO's SOLID principle and making it is impossible for me to customize it on a subclass.
I have refactored this method in 3 steps:
- Finding the usable URLs
- Checking if a node can be used for this request
- Executing the request
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulo-raca/lucene-solr master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit c7362262e868b9311e94c954e6e1c9f866776ed2
Author: Paulo Costa <pa...@geofusion.com.br>
Date: 2016-07-13T13:44:24Z
SOLR-9303: Refactor CloudSolrClient for extensibility
CloudSolrClient.sendRequest() is currently written as one big chunk of code, making it difficult to customize it on a subclass.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #51: SOLR-9303: Refactor CloudSolrClient for extens...
Posted by paulo-raca <gi...@git.apache.org>.
Github user paulo-raca closed the pull request at:
https://github.com/apache/lucene-solr/pull/51
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Labeledtree 201405a1
Posted by PaulElschot <gi...@git.apache.org>.
Github user PaulElschot closed the pull request at:
https://github.com/apache/lucene-solr/pull/51
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #51: SOLR-9303: Refactor CloudSolrClient for extensibility
Posted by paulo-raca <gi...@git.apache.org>.
Github user paulo-raca commented on the issue:
https://github.com/apache/lucene-solr/pull/51
Nobody cares, closing it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Labeledtree 201405a1
Posted by PaulElschot <gi...@git.apache.org>.
Github user PaulElschot commented on the pull request:
https://github.com/apache/lucene-solr/pull/51#issuecomment-105225333
See LUCENE-5627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org