You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2017/04/26 16:59:08 UTC

[GitHub] zeppelin pull request #2291: ZEPPELIN-2459 Zeppelin Usability Improvement fo...

GitHub user r-kamath opened a pull request:

    https://github.com/apache/zeppelin/pull/2291

    ZEPPELIN-2459 Zeppelin Usability Improvement for new paragraph

    ### What is this PR for?
    Move cursor to second line for new paragraphs
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    ZEPPELIN-2459
    
    ### How should this be tested?
    For a new paragraph he initial cursor position should be on the second line.
    
    ### Screenshots (if appropriate)
    **Before**
    <img width="324" alt="screen shot 2017-04-26 at 10 27 48 pm" src="https://cloud.githubusercontent.com/assets/2031306/25446579/9dcdeb2a-2acf-11e7-883d-e0ccf2ef834d.png">
    
    **After**
    <img width="394" alt="screen shot 2017-04-26 at 10 27 33 pm" src="https://cloud.githubusercontent.com/assets/2031306/25446593/a66289da-2acf-11e7-8d8e-2029339f0133.png">
    
    
    ### Questions:
    * Does the licenses files need update? n/a
    * Is there breaking changes for older versions? n/a
    * Does this needs documentation? n/a


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-2459

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2291
    
----
commit 4c6525d1c14f0f5727d5f7f2cc16b4b795e70d7a
Author: Renjith Kamath <re...@gmail.com>
Date:   2017-04-26T16:54:01Z

    ZEPPELIN-2459 Zeppelin Usability Improvement for new paragraph

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2291: ZEPPELIN-2459 Zeppelin Usability Improvement for new p...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2291
  
    Merging this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2291: ZEPPELIN-2459 Zeppelin Usability Improvement for new p...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2291
  
    @r-kamath Yeah, no problem. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2291: ZEPPELIN-2459 Zeppelin Usability Improvement for new p...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2291
  
    Tested locally, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2291: ZEPPELIN-2459 Zeppelin Usability Improvement for new p...

Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2291
  
    BTW, could we change the cursor to a slim line ? I heard people complain about the cursor too thick


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2291: ZEPPELIN-2459 Zeppelin Usability Improvement fo...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2291


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2291: ZEPPELIN-2459 Zeppelin Usability Improvement for new p...

Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:

    https://github.com/apache/zeppelin/pull/2291
  
    @zjffdu I think we should handle the cursor style in a different jira


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---