You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/07 15:52:21 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #995: Remove CONFIG_TLS
patacongo opened a new pull request #995:
URL: https://github.com/apache/incubator-nuttx/pull/995
## Summary
A first step in implementing the user-space error is force TLS to be enabled at all times. It is no longer optional
## Impact
High risk... Effects just about everything.
## Testing
Not yet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #995: Remove CONFIG_TLS
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #995:
URL: https://github.com/apache/incubator-nuttx/pull/995#discussion_r421629643
##########
File path: libs/libc/tls/tls_setelem.c
##########
@@ -31,7 +31,7 @@
#include <nuttx/tls.h>
#include <arch/tls.h>
-#ifdef CONFIG_TLS
+#ifdef CONFIG_TLS_NELEM > 0
Review comment:
```suggestion
#if CONFIG_TLS_NELEM > 0
```
##########
File path: libs/libc/tls/tls_getelem.c
##########
@@ -31,7 +31,7 @@
#include <nuttx/tls.h>
#include <arch/tls.h>
-#ifdef CONFIG_TLS
+#ifdef CONFIG_TLS_NELEM > 0
Review comment:
```suggestion
#if CONFIG_TLS_NELEM > 0
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org