[GitHub] kramasamy commented on a change in pull request #3160: Yaoli/fix dockerfiles

[GitBox <gi...@apache.org>]

kramasamy commented on a change in pull request #3160: Yaoli/fix dockerfiles
URL: https://github.com/apache/incubator-heron/pull/3160#discussion_r248565350
 
 

 ##########
 File path: docker/dist/Dockerfile.dist.centos7
 ##########
 @@ -37,11 +37,20 @@ WORKDIR /heron
 # run heron installer
 RUN /heron/heron-install.sh
 
-RUN mkdir -p /opt/heron && \
-    tar --strip-components=1 -m -zxvf /heron/heron-core.tar.gz -C /heron
+RUN ln -s /usr/local/heron/dist/heron-core /heron
+
+RUN mkdir -p /heron/heron-tools
+RUN ln -s /usr/local/heron/bin /heron/heron-tools
+RUN ln -s /usr/local/heron/conf /heron/heron-tools
+RUN ln -s /usr/local/heron/dist /heron/heron-tools
+RUN ln -s /usr/local/heron/lib /heron/heron-tools
+RUN ln -s /usr/local/heron/release.yaml /heron/heron-tools
+
+RUN ln -s /usr/local/heron/examples /heron
+
+RUN ln -s /usr/local/heron/release.yaml /heron
 
 Review comment:
   Multiple RUN commands increase the number of layers which increase the docker size - you need to optimize to get them into one single RUN command

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services