[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7544: Return 0 in the response metadata when thread cpu time measurement is disabled

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7544:
URL: https://github.com/apache/pinot/pull/7544#discussion_r725174677



##########
File path: pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentResultTableSingleValueQueriesTest.java
##########
@@ -1099,4 +1100,21 @@ public void testSelection() {
       Assert.assertEquals(resultTable.getRows().get(i), rows.get(i));
     }
   }
+
+  @Test
+  public void testThreadCpuTime() {
+    String query = "SELECT * FROM testTable";
+
+    ThreadTimer.setThreadCpuTimeMeasurementEnabled(true);
+    if (ThreadTimer.isThreadCpuTimeMeasurementEnabled()) {

Review comment:
       That is not true. I explicitly put this check in case the testing environment does not support `currentThreadCpuTime`. Let me add some comments in the test




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org