[GitHub] [pulsar] fantapsody commented on pull request #10612: Setup initial namespaces with MetadataStore

[GitBox <gi...@apache.org>]

fantapsody commented on pull request #10612:
URL: https://github.com/apache/pulsar/pull/10612#issuecomment-842738970


   > LGTM
   > 
   > We may have a problem with the new test case as the new refactored method may call System.exit, breaking the execution of the JVM.
   > 
   > I would be better to be able to pass to the PulsarInitialNamespaceSetup.main() function a callback to be executed in case of failure and use that version for tests
   > 
   > ```
   > PulsarInitialNamespaceSetup.main(arguments,  (exitCode) -> {
   >     fail the test
   > });
   > ```
   
   @eolivelli  Thanks for the idea! I modified the code in a similar way by moving the code from `main` to `doMain` and let `doMain` return a status code, please take another look. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org