You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/06/28 12:07:41 UTC
[GitHub] [camel-website] aashnajena opened a new pull request #416: Clean frontpage.css
aashnajena opened a new pull request #416:
URL: https://github.com/apache/camel-website/pull/416
Cleaned up frontpage.css to group css rules together and scope them better. Also made some changes to ensure content is better spaced, headings/margins are consistent for all frontpage sections and boxes from "projects" and "functionalities" section are aligned.
The icons in the "functionalities" section are used as images and use a complicated "filter" property to colour them blue. On my laptop, that colour doesn't really match the camel blue. I tried to use them as `<svg> <use href="path" /> </svg>` but this isn't working for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart merged pull request #416: refactor: cleanup frontpage.css
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #416:
URL: https://github.com/apache/camel-website/pull/416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] AemieJ commented on pull request #416: Clean frontpage.css
Posted by GitBox <gi...@apache.org>.
AemieJ commented on pull request #416:
URL: https://github.com/apache/camel-website/pull/416#issuecomment-651223559
https://issues.apache.org/jira/browse/CAMEL-15161?jql=project%20%3D%20CAMEL%20AND%20component%20%3D%20website
This issue dealt with reducing the space from the old functionality to new functionality as you can observe in the attachments. However, with your changes, if I just remove the border from the box it's the same issue as before.
The reason for this issue was to allow the user to see functionality in one look when it comes across the title but with yours, it reverts to same padding as before and covers too much space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] AemieJ commented on pull request #416: Clean frontpage.css
Posted by GitBox <gi...@apache.org>.
AemieJ commented on pull request #416:
URL: https://github.com/apache/camel-website/pull/416#issuecomment-650903855
The functionality section was designed in a manner to occupy lesser space however with the current changes, it is just a box design covering lots of space as it did before. Except for this, it is good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on pull request #416: refactor: cleanup frontpage.css
Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #416:
URL: https://github.com/apache/camel-website/pull/416#issuecomment-652881261
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] aashnajena commented on pull request #416: Clean frontpage.css
Posted by GitBox <gi...@apache.org>.
aashnajena commented on pull request #416:
URL: https://github.com/apache/camel-website/pull/416#issuecomment-651119551
@zregvart do we need to fix the "functionalities" section icons?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] aashnajena commented on pull request #416: Clean frontpage.css
Posted by GitBox <gi...@apache.org>.
aashnajena commented on pull request #416:
URL: https://github.com/apache/camel-website/pull/416#issuecomment-651115866
@AemieJ can you specify where a lot of space is getting occupied? I attempted to align the sections correctly, I didn't want to change the design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on pull request #416: Clean frontpage.css
Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #416:
URL: https://github.com/apache/camel-website/pull/416#issuecomment-652092978
> @zregvart do we need to fix the "functionalities" section icons?
We can, in a separate PR or in this one. What we do instead for the icons in the top navigation is to change the image background to change the fill color, we also use sprites to reduce the amount of requests to the server. See `brand-logos.svg`.
The [CAMEL-15161](https://issues.apache.org/jira/browse/CAMEL-15161) was about seeing that there is more content (like the Functionality section) above the fold on initial page load. From what I can see we can't for resolutions with height less than or equal to 768px. Not sure what above the fold height is the minimum we need to support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org