You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/05/03 20:40:39 UTC
Review Request: Log executor output to syslog.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10930/
-----------------------------------------------------------
Review request for mesos.
Description
-------
>From 0930bc1407551bfb318d7d950d1dc995aad02b77 Mon Sep 17 00:00:00 2001
From: Brenden Matthews <br...@airbnb.com>
Date: Tue, 30 Apr 2013 11:31:46 -0700
Subject: [PATCH 6/9] Log executor output to syslog.
---
src/slave/slave.cpp | 3 +++
1 file changed, 3 insertions(+)
Diffs
-----
src/slave/slave.cpp 86a15fc
Diff: https://reviews.apache.org/r/10930/diff/
Testing
-------
Used in production at airbnb.
Thanks,
Brenden Matthews
Re: Review Request: Log executor output to syslog.
Posted by Brenden Matthews <br...@diddyinc.com>.
> On May 4, 2013, 1:47 a.m., Vinod Kone wrote:
> > src/slave/slave.cpp, lines 2201-2203
> > <https://reviews.apache.org/r/10930/diff/1/?file=287639#file287639line2201>
> >
> > I'm curious why you had to do this?
I actually didn't really mean to submit this.
But, if you're curious, we use this with logstash + kibana as a way of analyzing the results of the tasks that run. This writes everything to rsyslogd which forwards them to logstash.
Feel free to discard this.
- Brenden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10930/#review20156
-----------------------------------------------------------
On May 3, 2013, 6:40 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10930/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 6:40 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> From 0930bc1407551bfb318d7d950d1dc995aad02b77 Mon Sep 17 00:00:00 2001
> From: Brenden Matthews <br...@airbnb.com>
> Date: Tue, 30 Apr 2013 11:31:46 -0700
> Subject: [PATCH 6/9] Log executor output to syslog.
>
> ---
> src/slave/slave.cpp | 3 +++
> 1 file changed, 3 insertions(+)
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 86a15fc
>
> Diff: https://reviews.apache.org/r/10930/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Log executor output to syslog.
Posted by Ben Mahler <be...@gmail.com>.
> On May 4, 2013, 1:47 a.m., Vinod Kone wrote:
> > src/slave/slave.cpp, lines 2201-2203
> > <https://reviews.apache.org/r/10930/diff/1/?file=287639#file287639line2201>
> >
> > I'm curious why you had to do this?
>
> Brenden Matthews wrote:
> I actually didn't really mean to submit this.
>
> But, if you're curious, we use this with logstash + kibana as a way of analyzing the results of the tasks that run. This writes everything to rsyslogd which forwards them to logstash.
>
> Feel free to discard this.
Cool! We can't discard others' changes, so you'll have to discard if you want this dropped.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10930/#review20156
-----------------------------------------------------------
On May 3, 2013, 6:40 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10930/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 6:40 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> From 0930bc1407551bfb318d7d950d1dc995aad02b77 Mon Sep 17 00:00:00 2001
> From: Brenden Matthews <br...@airbnb.com>
> Date: Tue, 30 Apr 2013 11:31:46 -0700
> Subject: [PATCH 6/9] Log executor output to syslog.
>
> ---
> src/slave/slave.cpp | 3 +++
> 1 file changed, 3 insertions(+)
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 86a15fc
>
> Diff: https://reviews.apache.org/r/10930/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: Log executor output to syslog.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10930/#review20156
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/10930/#comment41402>
I'm curious why you had to do this?
- Vinod Kone
On May 3, 2013, 6:40 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10930/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 6:40 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> From 0930bc1407551bfb318d7d950d1dc995aad02b77 Mon Sep 17 00:00:00 2001
> From: Brenden Matthews <br...@airbnb.com>
> Date: Tue, 30 Apr 2013 11:31:46 -0700
> Subject: [PATCH 6/9] Log executor output to syslog.
>
> ---
> src/slave/slave.cpp | 3 +++
> 1 file changed, 3 insertions(+)
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 86a15fc
>
> Diff: https://reviews.apache.org/r/10930/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>