You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/27 12:21:09 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4430: FIX issue in VR if remote access vpn is enabled
ravening opened a new pull request #4430:
URL: https://github.com/apache/cloudstack/pull/4430
## Description
<!--- Describe your changes in detail -->
Use both tcp protocol and module so that
vpn is enabled properly
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4430: FIX issue in VR if remote access vpn is enabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4430:
URL: https://github.com/apache/cloudstack/pull/4430#issuecomment-718225326
<b>Trillian test result (tid-3096)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33180 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4430-t3096-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4430: FIX issue in VR if remote access vpn is enabled
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4430:
URL: https://github.com/apache/cloudstack/pull/4430#issuecomment-718479516
looks good but i am not sure why protocol would improve on the vpn instead of just restrict it. no regressions so i'm fine with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4430: FIX issue in VR if remote access vpn is enabled
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4430:
URL: https://github.com/apache/cloudstack/pull/4430#issuecomment-717258736
@ravening can you give this a priority? as we are in code freeze, do we need this before 4.15?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4430: FIX issue in VR if remote access vpn is enabled
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4430:
URL: https://github.com/apache/cloudstack/pull/4430#issuecomment-717884172
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4430: FIX issue in VR if remote access vpn is enabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4430:
URL: https://github.com/apache/cloudstack/pull/4430#issuecomment-717874356
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4430: FIX issue in VR if remote access vpn is enabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4430:
URL: https://github.com/apache/cloudstack/pull/4430#issuecomment-717884474
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4430: FIX issue in VR if remote access vpn is enabled
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4430:
URL: https://github.com/apache/cloudstack/pull/4430#issuecomment-717857930
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4430: FIX issue in VR if remote access vpn is enabled
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4430:
URL: https://github.com/apache/cloudstack/pull/4430
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4430: FIX issue in VR if remote access vpn is enabled
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4430:
URL: https://github.com/apache/cloudstack/pull/4430#issuecomment-717857534
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4430: FIX issue in VR if remote access vpn is enabled
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4430:
URL: https://github.com/apache/cloudstack/pull/4430#issuecomment-717259833
> @ravening can you give this a priority? as we are in code freeze, do we need this before 4.15?
@DaanHoogland yes its good to have this before 4.15 as its a bug fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org