You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2020/01/15 19:48:33 UTC
[GitHub] [myfaces] volosied opened a new pull request #79: MYFACES-3822
remove unused params from JSF 2.2.x
volosied opened a new pull request #79: MYFACES-3822 remove unused params from JSF 2.2.x
URL: https://github.com/apache/myfaces/pull/79
A number of unused params were removed, but they have been remained in MyFacesConfig
https://issues.apache.org/jira/browse/MYFACES-3822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] volosied commented on issue #79: MYFACES-3822 remove
unused params from JSF 2.2.x
Posted by GitBox <gi...@apache.org>.
volosied commented on issue #79: MYFACES-3822 remove unused params from JSF 2.2.x
URL: https://github.com/apache/myfaces/pull/79#issuecomment-576438167
Been a bit busy, but I will get the other branches done soon!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] pnicolucci commented on issue #79: MYFACES-3822 remove
unused params from JSF 2.2.x
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on issue #79: MYFACES-3822 remove unused params from JSF 2.2.x
URL: https://github.com/apache/myfaces/pull/79#issuecomment-576475328
@volosied I agree with @tandraschko here. It makes more sense to do the clean up in the 2.3 and master branches. Can you explain what you mean by your comment:
For backwards compatibility (based on comments), the following were left alone
org.apache.myfaces.HANDLE_STATE_CACHING_MECHANICS org.apache.myfaces.SAVE_STATE_WITH_VISIT_TREE_ON_PSS
org.apache.myfaces.ERROR_HANDLER
org.apache.myfaces.CACHE_OLD_VIEWS_IN_SESSION_MODE
I didn't actually see those in the MyFacesConfig, did I miss them?
Also the commit history would be a bit easier to follow here if we just used one commit to remove these params rather than one for each removal, just my opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] volosied commented on issue #79: MYFACES-3822 remove
unused params from JSF 2.2.x
Posted by GitBox <gi...@apache.org>.
volosied commented on issue #79: MYFACES-3822 remove unused params from JSF 2.2.x
URL: https://github.com/apache/myfaces/pull/79#issuecomment-577884352
@pnicolucci In that case, I can close this PR then without merging it in.
As for your question, I saw comments saying those 4 parameters were deprecated, but after taking a closer look, I believe their functionality was removed. (Since I don't see mentions of the them anywhere else in the code.) They aren't in the MyFacesConfig, but in the following files:
org.apache.myfaces.HANDLE_STATE_CACHING_MECHANICS
impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlResponseStateManager.java
org.apache.myfaces.SAVE_STATE_WITH_VISIT_TREE_ON_PSS
impl/src/main/java/org/apache/myfaces/view/facelets
/DefaultFaceletsStateManagementStrategy.java
org.apache.myfaces.ERROR_HANDLER
api/src/main/java/javax/faces/webapp/PreJsf2ExceptionHandlerFactory.java
org.apache.myfaces.CACHE_OLD_VIEWS_IN_SESSION_MODE
impl/src/main/java/org/apache/myfaces/application/viewstate/ServerSideStateCacheImpl.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #79: MYFACES-3822 remove
unused params from JSF 2.2.x
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #79: MYFACES-3822 remove unused params from JSF 2.2.x
URL: https://github.com/apache/myfaces/pull/79#issuecomment-574830311
Hmpf, i general i don't have a problem to do such cleanups, however i personally see 2.2 and everything older in maintanence mode
@pnicolucci WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko commented on issue #79: MYFACES-3822 remove
unused params from JSF 2.2.x
Posted by GitBox <gi...@apache.org>.
tandraschko commented on issue #79: MYFACES-3822 remove unused params from JSF 2.2.x
URL: https://github.com/apache/myfaces/pull/79#issuecomment-578036021
yep, lets close it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko edited a comment on issue #79: MYFACES-3822
remove unused params from JSF 2.2.x
Posted by GitBox <gi...@apache.org>.
tandraschko edited a comment on issue #79: MYFACES-3822 remove unused params from JSF 2.2.x
URL: https://github.com/apache/myfaces/pull/79#issuecomment-574830311
Hmpf, i general i don't have a problem to do such cleanups, however i personally see 2.2 and everything older in maintanence mode
@pnicolucci WDYT?
big +1 to remove it on 2.3 and master of course
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] volosied commented on issue #79: MYFACES-3822 remove
unused params from JSF 2.2.x
Posted by GitBox <gi...@apache.org>.
volosied commented on issue #79: MYFACES-3822 remove unused params from JSF 2.2.x
URL: https://github.com/apache/myfaces/pull/79#issuecomment-574828738
Some of the tests will also need to be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] tandraschko closed pull request #79: MYFACES-3822 remove
unused params from JSF 2.2.x
Posted by GitBox <gi...@apache.org>.
tandraschko closed pull request #79: MYFACES-3822 remove unused params from JSF 2.2.x
URL: https://github.com/apache/myfaces/pull/79
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [myfaces] volosied commented on issue #79: MYFACES-3822 remove
unused params from JSF 2.2.x
Posted by GitBox <gi...@apache.org>.
volosied commented on issue #79: MYFACES-3822 remove unused params from JSF 2.2.x
URL: https://github.com/apache/myfaces/pull/79#issuecomment-574835091
I see, but I'll go ahead and continue making similar changes to 2.3 and master! Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services