You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/05/10 12:21:51 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #2231: HDDS-5203. Allow suppressing deprecation warning for HADOOP_ variables
adoroszlai opened a new pull request #2231:
URL: https://github.com/apache/ozone/pull/2231
## What changes were proposed in this pull request?
HDDS-4525 deprecated `HADOOP_*` variables in Ozone in favor of corresponding `OZONE_*` variables. This change allows suppressing the deprecation warning by setting `OZONE_DEPRECATION_WARNING=false`.
https://issues.apache.org/jira/browse/HDDS-5203
## How was this patch tested?
Added new acceptance test case for `OZONE_DEPRECATION_WARNING=false`.
https://github.com/adoroszlai/hadoop-ozone/runs/2544900937#step:6:870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2231: HDDS-5203. Allow suppressing deprecation warning for HADOOP_ variables
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2231:
URL: https://github.com/apache/ozone/pull/2231#issuecomment-839145540
Thanks @ayushtkn and @dineshchitlangia for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2231: HDDS-5203. Allow suppressing deprecation warning for HADOOP_ variables
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2231:
URL: https://github.com/apache/ozone/pull/2231#issuecomment-836857022
@dineshchitlangia Thanks for taking a look.
> How does it make the upgrade easier? My understanding is that since this is a warning it should cause any failures/error/process termination.
Correct, it's only a warning, does not cause any failure.
We deprecated the `HADOOP_*` variables in favor of `OZONE_*` ones mainly to be able to define different values for a co-existing Hadoop + Ozone installation. In an existing Ozone install where one doesn't need that flexibility, we can live with `HADOOP_*`, but the warning printed for each CLI command may be annoying anyway. The ability to suppress the warning makes upgrade easier because otherwise you would have to rename all the other variables just to get rid of the warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dineshchitlangia commented on pull request #2231: HDDS-5203. Allow suppressing deprecation warning for HADOOP_ variables
Posted by GitBox <gi...@apache.org>.
dineshchitlangia commented on pull request #2231:
URL: https://github.com/apache/ozone/pull/2231#issuecomment-836777869
@adoroszlai Why do we need to suppress the warning ? How does it make the upgrade easier?
My understanding is that since this is a warning it should cause any failures/error/process termination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2231: HDDS-5203. Allow suppressing deprecation warning for HADOOP_ variables
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2231:
URL: https://github.com/apache/ozone/pull/2231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org