You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/29 03:05:37 UTC
[GitHub] [iceberg] xingbowu opened a new pull request #3200: CodeStyle: Single blank line around method in interface
xingbowu opened a new pull request #3200:
URL: https://github.com/apache/iceberg/pull/3200
A single blank line may also appear around method in interface, it improves readability , I leave PR here to address it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] xingbowu commented on pull request #3200: CodeStyle: Single blank line around method in interface
Posted by GitBox <gi...@apache.org>.
xingbowu commented on pull request #3200:
URL: https://github.com/apache/iceberg/pull/3200#issuecomment-930694534
Thanks @jackye1995 for taking attention on this problem.
Yes, In current build, it doesn't check this rule no matter 0~2 or sth else. I am not sure which process should check it.
Regarding to the correct configuration, Whether BLANK_LINES_AROUND_METHOD_IN_INTERFACE as 0 is per original purpose or not?I am not sure who the owner of codesytle is? also involve @rdblue @openinx to give more suggestions.
IMO, A single blank line around method in interface, it is more readability.
I checked existed code, most of them followed up this rule with single blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3200: CodeStyle: Single blank line around method in interface
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3200:
URL: https://github.com/apache/iceberg/pull/3200#issuecomment-950011653
Overall we follow the convention of 1 blank line between all methods anyway. I think it does not work because what you are changing is the intellij style, which does not affect the actual check style. The correct file to change is https://github.com/apache/iceberg/blob/master/.baseline/checkstyle/checkstyle.xml#L39-L43, but it already disallows more than 1 consecutive blank lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3200: CodeStyle: Single blank line around method in interface
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3200:
URL: https://github.com/apache/iceberg/pull/3200#issuecomment-930671163
I tried to change the value to 2 and see what happens, and my build can still pass, are you sure this is the right config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org