You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/25 11:01:43 UTC
[GitHub] [shardingsphere-elasticjob] vran-dev opened a new pull request #1501: Add Pre-Check for param `elasticJob` in JobScheduler's constructor
vran-dev opened a new pull request #1501:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1501
Fixes #1496
Changes proposed in this pull request:
- Do Pre-check for param elasticJob
- Give more clearly error message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu closed pull request #1501: Add Pre-Check for param `elasticJob` in JobScheduler's constructor
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #1501:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] vran-dev commented on a change in pull request #1501: Add Pre-Check for param `elasticJob` in JobScheduler's constructor
Posted by GitBox <gi...@apache.org>.
vran-dev commented on a change in pull request #1501:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1501#discussion_r494941768
##########
File path: elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/JobScheduler.java
##########
@@ -53,7 +54,7 @@
private final CoordinatorRegistryCenter regCenter;
private final String elasticJobType;
-
Review comment:
thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1501: Add Pre-Check for param `elasticJob` in JobScheduler's constructor
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1501:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1501#discussion_r494927404
##########
File path: elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/JobScheduler.java
##########
@@ -53,7 +54,7 @@
private final CoordinatorRegistryCenter regCenter;
private final String elasticJobType;
-
Review comment:
Keep indents (including blank lines) consistent with the previous one.
Refer to https://shardingsphere.apache.org/community/en/contribute/code-conduct/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] vran-dev commented on a change in pull request #1501: Add Pre-Check for param `elasticJob` in JobScheduler's constructor
Posted by GitBox <gi...@apache.org>.
vran-dev commented on a change in pull request #1501:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1501#discussion_r494941768
##########
File path: elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/JobScheduler.java
##########
@@ -53,7 +54,7 @@
private final CoordinatorRegistryCenter regCenter;
private final String elasticJobType;
-
Review comment:
thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1501: Add Pre-Check for param `elasticJob` in JobScheduler's constructor
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1501:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1501#discussion_r494927404
##########
File path: elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/JobScheduler.java
##########
@@ -53,7 +54,7 @@
private final CoordinatorRegistryCenter regCenter;
private final String elasticJobType;
-
Review comment:
Keep indents (including blank lines) consistent with the previous one.
Refer to https://shardingsphere.apache.org/community/en/contribute/code-conduct/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org