You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by an...@apache.org on 2015/12/17 23:40:41 UTC
jena git commit: Clarify the clarification.
Repository: jena
Updated Branches:
refs/heads/master 590c06a89 -> 07db5bfd4
Clarify the clarification.
Project: http://git-wip-us.apache.org/repos/asf/jena/repo
Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/07db5bfd
Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/07db5bfd
Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/07db5bfd
Branch: refs/heads/master
Commit: 07db5bfd4d4bbf156d5086a745470c10e78e87f6
Parents: 590c06a
Author: Andy Seaborne <an...@apache.org>
Authored: Thu Dec 17 22:40:28 2015 +0000
Committer: Andy Seaborne <an...@apache.org>
Committed: Thu Dec 17 22:40:28 2015 +0000
----------------------------------------------------------------------
.../jena/sparql/modify/UpdateEngineWorker.java | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jena/blob/07db5bfd/jena-arq/src/main/java/org/apache/jena/sparql/modify/UpdateEngineWorker.java
----------------------------------------------------------------------
diff --git a/jena-arq/src/main/java/org/apache/jena/sparql/modify/UpdateEngineWorker.java b/jena-arq/src/main/java/org/apache/jena/sparql/modify/UpdateEngineWorker.java
index e3a21a6..1f4de10 100644
--- a/jena-arq/src/main/java/org/apache/jena/sparql/modify/UpdateEngineWorker.java
+++ b/jena-arq/src/main/java/org/apache/jena/sparql/modify/UpdateEngineWorker.java
@@ -367,18 +367,17 @@ public class UpdateEngineWorker implements UpdateVisitor
// and an empty/unknown graph <uri>
// rewrite with GRAPH -> no match.
// redo as dataset with different default graph -> match
- // SPARQL is unclear abotu what happens when the graph does not exist.
- // The rewite means the raw query engine is used though.
+ // SPARQL is unclear about what happens when the graph does not exist.
+ // but the rewrite with ElementNamedGraph is closer to SPARQL.
// Ye Olde way - create a special dataset
- dsg = processWith(update) ;
+ dsg = processWithOld(update) ;
withGraph = null ;
}
else
- // Better,
- // Wrap WHERE clause in GRAPH <with_uri>
- // and can remove DatasetGraphAltDefaultGraph,
- // or at least comment its implications.
+ // Better, treat as
+ // WHERE { GRAPH <with> { ... } }
+ // This is the SPARQL wording (which is a bit loose).
elt = new ElementNamedGraph(withGraph, elt) ;
}
@@ -428,7 +427,7 @@ public class UpdateEngineWorker implements UpdateVisitor
return DynamicDatasets.dynamicDataset(update.getUsing(), update.getUsingNamed(), datasetGraph, false);
}
- protected DatasetGraph processWith(UpdateModify update) {
+ protected DatasetGraph processWithOld(UpdateModify update) {
Node withGraph = update.getWithIRI();
if ( withGraph == null )
return null;